Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [emf-dev] [CDO] Reduce dependencies in SQLQueryHandler

Am 13.02.2017 um 17:03 schrieb Erdal Karaca:
I would like to wrap the SQLQueryHandler in a custom query handler and make it available via an IQueryHandlerProvider. At the moment, this is not possible as SQLQueryHandler has a dependency to DBStoreAccessor which is not used.

Do I miss something? If not, I would like to patch the class.
It's not natural for the SQLQueryHandler to *not* depend on the DBStoreAccessor (see my previous reply). What if the query handler needs other server.db components in the future? SQLQueryHandler is internal to the server.db plugin and I'm against changing it for external desires.

If you don't want to copy its code you're best off with creating a fake implementation of IDBStoreAccessor that only provides getStore() (possibly a fake, too, that only provides the IIDHandler) and getDBConnection().



Back to the top