Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ejb-dev] [cdi-dev] Moving optional EJB tests from CDI to be required tests of EJB


On 8/26/21 9:49 AM, Scott Marlow wrote:


On 8/25/21 10:55 PM, Scott Stark wrote:
  1. I'm all for the downstream container tests moving into the container projects. We have touched on this in previous discussions about cleaning up circularity between specs and TCKs.
  2. Those numbers don't add up with what I currently count on the cdi-tck main branch where the tests have been split into a set of core tests that don't have downstream api dependencies (servlet, ejb, transactions, jus, ...) and a web profile set of tests. I count 1322 in the core and 658 in the web for a total of 1980 currently. Counting just @Test (which is what I did as well) will over count because some test classes have this annotation at both the class and method level, but 
  3. Can you find an example of an EJB test you don't think is being run in the web/platform runs?

+1, I'll take a look also.

For reference for how to opt into Web Profile + Full Platform, according to https://github.com/eclipse-ee4j/cdi-tck/blob/master/doc/reference/src/main/asciidoc/executing.asciidoc:

"

Running the Tests In the Container - Core and EE parts

To execute tests within Core and EE parts of the specification you need to use in-container mode with the JBoss TCK runner, you first have to setup WildFly as described in the [running-against-weld] callout.

Then, execute the TCK runner with Maven as follows:

mvn test -Dincontainer

The presence of the incontainer property activates an incontainer Maven profile. This time, all the tests except the tests within SE TestNG group are executed.

In order to run tests appropriate to the Jakarta EE Web Profile execute:

mvn test -Dincontainer=webprofile

"

  1. I'm fine with pulling the current EJB related tests and moving them somewhere. Just need to know where.

On Aug 25, 2021 at 4:25:45 PM, David Blevins <dblevins@xxxxxxxxxxxxx> wrote:
I'm mentioning something I don't really have the time to work on myself at this time, but it still should be brought up.

There are EJB-specific spec requirements in the CDI spec.  There are a few hundred tests in the CDI TCK that are for EJB specifically and enforce these requirements.  From a CDI perspective all these requirements and tests are optional.

CDI became a permanent dependency of EJB in EJB 3.1.  It is somewhat indirect, but that's how the math works out; you can't have an EJB implementation that does not support CDI including CDI decorators.  Therefore, from an EJB perspective all these "optional" tests are actually required.  No one should be allowed to claim Jakarta EE Web Profile or Platform compliance without passing these EJB+CDI integration tests.

At the moment it's difficult to tell who if anyone is running these tests.  I count 2,767 uses of org.testng.annotations.Test in the CDI TCK, yet I see most our certification requests for Web Profile and Platform show 1796 CDI tests run.  It seems we've all overlooked them -- in fairness they are marked optional.

What do people think about moving these EJB-specific requirements and tests into the EJB spec and TCK and marking them required?


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

_______________________________________________
cdi-dev mailing list
cdi-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdi-dev

_______________________________________________
cdi-dev mailing list
cdi-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdi-dev

Back to the top