Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r
  • From: "KARR, DAVID" <dk068x@xxxxxxx>
  • Date: Tue, 18 Feb 2025 22:53:14 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=att.com; dmarc=pass action=none header.from=att.com; dkim=pass header.d=att.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lIX0GER+fIN69Eq+djvxGyuu+vnVbR6InYZhGEvuRFY=; b=tmQF3IAr88QfOdPaA0KIyoFhwPXrERUBuSabE+jVl4iiplPU4t6Ij0ekm73Cu4Mvj/TZ0+IkpzChvRBk0+QMHoCHAhEF3Z6rWEbLFbCL2EDLoQr4PDok+6id0sXivrLUhyzeiqL+WnhiExDBV/xjQhz06N+8nvTsgfuqU1/PVptQZnR8ADiORAXT3IvBBuyyB1aCyrwH3lyym9aA9wT6KbyPM5mGHNZAkjsc5cXdhEDmuBlJKdaNkfJiP5ZwmFV8iqqKTdRMEbv0WocQk1AwJDo3lj/iOXULtPDrcP+Qf5JElM2RqHxf6MLzia8JnisfU3KX8HYMueIHKq2y9mW6uQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ctqgxw+m/nYacvTl40Muvz4JgD3cLV9InS3svJCQOQ6+OgWQIbawq8GUSTJc/Zlue7wcWSHXd+kHRxygvCfZaVEK0TJjDT/S26pHn8lptUzWlNsO3Qabya3AqE9Y0LCoj3wi072M/D22CT92vYN1HCLD3s33UQxFBZ2uFRWXgoiNOfPv0CDxRklp0feoAZSxdYudcFsdk7QtUuJCcjn7CiHKTj3w9RimOSR6mExq2beHvKWElIxxDJMWxitNPkDb5TjzNpvxWBjZmfj3MpNdplwZrI7MZANdC4GR+0hliz32eeNPL7PAenwYdQhHBFwSmP0XaNj6jhGmt5vxzu1CWg==
  • Delivered-to: egit-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/egit-dev/>
  • List-help: <mailto:egit-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/egit-dev>, <mailto:egit-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/egit-dev>, <mailto:egit-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: Adt5hN1guWAWdSVaTgCc9qwiBw05+gADsWoAAC3ky7AAI/DPSQA7HTgQAJt9bQAAAzr0gAD9ZqHQAAGDEgAABnALoA==
  • Thread-topic: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

So far, we are only seeing this symptom in Anypoint Studio. Using this local development environment, will I be able to run this test case in Anypoint Studio, or will it only let me run it in that local development environment?

 

From: Matthias Sohn <matthias.sohn@xxxxxxxxx>
Sent: Tuesday, February 18, 2025 11:48 AM
To: KARR, DAVID <dk068x@xxxxxxx>
Cc: EGit developer discussion <egit-dev@xxxxxxxxxxx>; Sohn, Matthias <matthias.sohn@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

You can try to use our automated Oomph setup to install an Eclipse IDE configured for jgit and egit development. Checkout the version you want to debug, set the egit target platform matching your Eclipse version and you should be able to debug

You can try to use our automated Oomph setup to install an Eclipse IDE configured for jgit and egit development.

Checkout the version you want to debug, set the egit target platform matching your Eclipse version and you

should be able to debug what's going on.

 

 

On Tue, Feb 18, 2025 at 8:05PM KARR, DAVID <dk068x@xxxxxxx> wrote:

Is there any way to make jgit more verbose? We have verified that this is only a problem on Windows. The Mac users of the same version of Anypoint Studio are not seeing this problem.

 

From: Matthias Sohn <matthias.sohn@xxxxxxxxx>
Sent: Thursday, February 13, 2025 10:09 AM
To: KARR, DAVID <dk068x@xxxxxxx>
Cc: EGit developer discussion <egit-dev@xxxxxxxxxxx>; Sohn, Matthias <matthias.sohn@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

On Thu, Feb 13, 2025 at 5:38 PM KARR, DAVID <dk068x@att.com> wrote: I’ve now gotten him to update to the latest version of Anypoint Studio, version 7.21, which uses egit 6.9.0.202403050737 . It still is not working. He has also verified

On Thu, Feb 13, 2025 at 5:38PM KARR, DAVID <dk068x@xxxxxxx> wrote:

I’ve now gotten him to update to the latest version of Anypoint Studio, version 7.21, which uses egit 6.9.0.202403050737 . It still is not working.  He has also verified that other team members using the same configuration are getting the same result. This is not working for any of them using Anypoint Studio on Windows. I think all of them use Windows, but I’ll verify that.

 

I can't check since I have no Windows machine available and didn't use any in the last decade. 

 

From: egit-dev <egit-dev-bounces@xxxxxxxxxxx> On Behalf Of KARR, DAVID via egit-dev
Sent: Monday, February 10, 2025 6:25 AM
To: Sohn, Matthias <matthias.sohn@xxxxxxx>; EGit developer discussion <egit-dev@xxxxxxxxxxx>; Matthias Sohn <matthias.sohn@xxxxxxxxx>
Cc: KARR, DAVID <dk068x@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

He was able to upgrade, but only to Anypoint 7.17 and now Git version is 6.6.0.202305301015. It is still not running the hook. I believe he is constrained by the version of Mulesoft this supports, but I will verify that. From: Sohn, Matthias

He was able to upgrade, but only to Anypoint 7.17 and now Git version is 6.6.0.202305301015. It is still not running the hook. I believe he is constrained by the version of Mulesoft this supports, but I will verify that.

 

From: Sohn, Matthias <matthias.sohn@xxxxxxx>
Sent: Sunday, February 9, 2025 2:17 AM
To: EGit developer discussion <egit-dev@xxxxxxxxxxx>; Matthias Sohn <matthias.sohn@xxxxxxxxx>
Cc: KARR, DAVID <dk068x@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

Ok, good to know 😊. I can’t check since I don’t have any Windows machine available. If you can update Anypoint Studio to Eclipse 4.28 (2023-06) you can try to update to EGit 7.1.0.202411261347-r. From: egit-dev <egit-dev-bounces@eclipse.org>

 

Ok, good to know 😊. I can’t check since I don’t have any Windows machine available.

If you can update Anypoint Studio to Eclipse 4.28 (2023-06) you can try to update

to EGit 7.1.0.202411261347-r.

 

 

From: egit-dev <egit-dev-bounces@xxxxxxxxxxx> on behalf of KARR, DAVID via egit-dev <egit-dev@xxxxxxxxxxx>
Date: Saturday, 8. February 2025 at 18:07
To: Matthias Sohn <matthias.sohn@xxxxxxxxx>, EGit developer discussion <egit-dev@xxxxxxxxxxx>
Cc: KARR, DAVID <dk068x@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

(I would post after, but Outlook is being a pain.)

 

I don’t understand what you are saying. Perhaps there’s one point I made that is not completely clear. This hook is working perfectly fine in recent versions of Eclipse on Windows. That means it is working with JGit on Windows.  What is not working is doing the same thing in Anypoint studio on Windows, which uses that old version of Egit.

 

From: Matthias Sohn <matthias.sohn@xxxxxxxxx>
Sent: Friday, February 7, 2025 11:08 AM
To: EGit developer discussion <egit-dev@xxxxxxxxxxx>
Cc: KARR, DAVID <dk068x@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

On Fri, Feb 7, 2025 at 6:41 PM KARR, DAVID via egit-dev <egit-dev@eclipse.org> wrote: I've been working on a local git hook to perform certain validations. It is working fine with the git command line and with recent versions of Eclipse.

On Fri, Feb 7, 2025 at 6:41PM KARR, DAVID via egit-dev <egit-dev@xxxxxxxxxxx> wrote:

I've been working on a local git hook to perform certain validations.  It is working fine with the git command line and with recent versions of Eclipse.  I'm working with a user who is using the Mulesoft Anypoint Studio on Windows, which uses older versions of the Eclipse platform.  This is using version 6.5.0.202303070854-r of eGit.

My git hook is set up with a tiny bash script in C:\Users\<userid>\.githooks\commit-msg .  That one-line script just executes the native application I constructed. The "hooksPath" property is set in the user's .gitconfig file.  The application also looks for debug properties in .gitconfig to write to a log file. Again, this is all working fine with git on the command line, including the log file.

When this user tries to create a commit from Anypoint Studio that is invalid according to the code in the git hook, it lets the commit proceed. Nothing appears in the log file for the hook. When he does this from the git command line, it properly blocks it.

We have verified in Preferences in Studio that it thinks the user's git configuration is in the location we expect, and it has all the properties we expect.

Is it possible that this old version of eGit (released almost two years ago) is doing something different to check the user's .gitconfig and executing hooks?

 

Running the hooks via FS.runHookIfPresent() in JGit is currently only implemented in FS_Posix

This means there is no implementation for Windows yet.

 

 

Contributions are welcome :-)

 

-Matthias


Back to the top