Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Git Staging view enhancements to contribute

Thanks, Matthias.  Last night I amended my commit to fix a problem that I discovered during testing, and this time the build and tests were successful.

 

From: Matthias Sohn [mailto:matthias.sohn@xxxxxxxxx]
Sent: Thursday, May 09, 2013 11:13 PM
To: Steve Elsemore
Cc: egit-dev@xxxxxxxxxxx
Subject: Re: [egit-dev] Git Staging view enhancements to contribute

 

On Thu, May 9, 2013 at 6:03 PM, Steve Elsemore <selsemore@xxxxxxxxxx> wrote:

Hi, Matthias.  Since this is my first attempt at an EGit contribution, could you  possibly give me some guidance on how to proceed?

I've filed an issue for my enhancement:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=407607

And I've pushed my changes to Gerrit for review:

https://git.eclipse.org/r/#/c/12676/

The build is unstable due to failure of one of the SWTBot tests:

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4499/testReport/junit/org.eclipse.egit.ui.view.repositories/GitRepositoriesViewBranchHandlingTest/testCreateDeleteLocalBranchWithUnmerged/

The test failure would seem to be unrelated to my changes, and the test runs successfully for me locally.  Can you give me any advice about how to figure out the cause of the failure and/or how to proceed from here?

 

it's hard to make UI tests 100% stable, sometimes they fail due to e.g. build server being busy with another job.

So we usually first rerun a failed UI test run on Hudson to check if a failure was caused by such an event.

 

--

Matthias 


Back to the top