Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] FileDiff and FileDiffLabelProvider

On Sat, Apr 2, 2011 at 2:06 AM, Christian Halstrick
<christian.halstrick@xxxxxxxxx> wrote:
> +1, you can make it public for now. But in the end we should move that
> code to JGit.
> This code depends on EGit/Eclipse only in one method (getProjectRelativePath()).
> Since also JGit users might want want such a method it would be better to have
> it in JGit.

Agreed, JGit is the right home.

> BTW: I see that this code hardcoded uses the diff algorithm
> MyersDiff() although we have
> algorithms producing better results. This should be fixed also.

Let's just make the algorithm settable like we do in Diff pgm (and elsewhere)


Chris Aniszczyk
+1 512 961 6719

Back to the top