[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [egit-dev] Git decorator - initial run when Eclipse starts up
|
2011/1/28 Alex Blewitt <alex.blewitt@xxxxxxxxx>:
> On 28 Jan 2011, at 09:51, Thun, Philipp wrote:
>
> Just a short update on this issue…
>
> After some additional analyses of the code I found the problem. We have a
> ResourceChangeListener that fires a LabelProviderChangedEvent containing the
> elements to be updated. After importing a project, all resources are treated
> as ADDED and this results in a decoration of all resources. When removing
> the elements array from the LabelProviderChangedEvent constructor and firing
> a generic event, this problem is solved, i.e. only visible elements are
> decorated.
>
> This doesn't seem to address the issue of whether files in the repository
> are determined to be 'team' files, though. Regardless of decorator
> performance changes, we should be marking the .git directory and children to
> be part of the team generated sets.
> This isn't just a semantic distinction, as other plugins will traverse all
> files in a project and skip team files explicitly; so fixing the eGit
> decorator isn't going to help them.
Anything missing here which isn't fixed by
http://egit.eclipse.org/r/#change,2335 ?
--
Matthias