Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Are additional Gerrit IP Review status possible?

Am 20.05.2010 17:35, schrieb Shawn O. Pearce:
>> * A patch needs a CQ / no CQ necessary
>> * CQ filed (with CQ number and link)
>> * CQ approved / rejected
> The problem with this is... these flags have to be supplied in
> order to submit a change.  So if we add the last one, every change
> would have "CQ approved" on it, even if it was written by a project
> committer and doesn't require a CQ.  I feel that is too misleading
> to be useful.

Not a big deal, we can be pragmatic and combined one and three:

* no CQ necessary, CQ approved, CQ rejected :)


Gunnar Wagenknecht

Back to the top