Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] CQs and committing to master 
Chris Aniszczyk <zx@xxxxxxxxxxxxxxxxx> wrote:
> On Mon, Oct 5, 2009 at 8:19 AM, Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
> > It seems the CQ is causing a backlogette at the moment. How does gerrit
> > handle branching; could we have a branch for items needing a CQ and then let
> > other items overtake later and get the CQ stuff merged back in?
> 
> I believe Shawn is on vacation this week

Unfortunately I had to make a last minute change in my vacation
plans.  I'm in the office this week and have had to reschedule the
vacation two weeks into the future (Oct 18-25).

> and he had an idea on how to do
> this. As far as I know, it was a manual process for now. We'll have to wait
> for his return unless someone else knows ;)

It is a manual process, I have to edit the database to redirect
the current changes onto the new branches.  If the branches had
existed before I uploaded the changes, they could have been created
correctly.
 
> I'm still getting my hands into Gerrit as I have some ideas on how to use it
> at Eclipse. The one thing that Gerrit is missing is some generic workflow
> support which I created a bug for:
> 
> http://code.google.com/p/gerrit/issues/detail?id=288
> 
> Once you have that in place, you can do some interesting things.

Yup.

I was thinking about this more the other day.  Maybe we want to
add a tag/label feature like the issue tracker on code.google.com.

Rules could add/remove tags and control submit, e.g.:

  if inserted lines >250 and not committer add label IP-Review-Required;
  if IP-Review-Required then submit only if IP-Review-Completed present;
  IP-Review-Required settable only by rules;
  IP-Review-Completed settable only by Janet et.al.;

Etc.

The current Code Review -2..+2 system would turn into
labels, e.g. CodeReview-Approved, CodeReview-LooksGood,
CodeReview-DoNotSubmit.

If labels are indexed similar to the way they are on code.google.com
we could then search for them.  That would make it easier to
write a query such as

  CodeReview-Approved IP-Review-Required -IP-Review-Completed

to pick up changes which Janet's team needs to look at, were approved
for submission regarding design/quality of code, but have not yet
completed the IP review process.

Eh, a bit off topic for egit-dev.

-- 
Shawn.

Back to the top