|Re: [eclipselink-dev] EclipseLink OXM Bug 440413|
Thanks for taking a look, and the comments on the patch. The full "test-oxm" OXM tests should run nice and clean for you in about 15 minutes with these changes applied.
With regard to the use of instanceof vs. using getClass(), the fix is in-line with the existing XMLConversionManager code, using instanceof, (presumably?) to allow for standard Java core type subclasses to also be converted. I think that optimizing the performance of conversion operations within the XMLConversionManager is a great idea for a further enhancement effort of this class, at some point.
On 30/09/2015 5:59 PM, Marcel Valovy wrote:
Back to the top