Hi Marcel,
Thanks for taking a look, and the comments on the patch. The full
"test-oxm" OXM tests should run nice and clean for you in about 15
minutes with these changes applied.
With regard to the use of instanceof vs. using getClass(), the fix
is in-line with the existing XMLConversionManager code, using
instanceof, (presumably?) to allow for standard Java core type
subclasses to also be converted. I think that optimizing the
performance of conversion operations within the XMLConversionManager
is a great idea for a further enhancement effort of this class, at
some point.
-David
On 30/09/2015 5:59 PM, Marcel Valovy
wrote:
Hi David,
Change seems justified to me and patch looks good. I will
finish the review in the morning when I run tests on my
machine. One thing that can be improved performance-wise is to
avoid instanceof and use .getClass() == BigDecimal.class as
instanceof traverses the whole inheritance tree.
Best regards
Marcel
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
--
David Minsky | Principal Member of Technical
Staff | +1 613-288-4605
Oracle Sustaining Engineering |
Application Server
45 O'Connor Street, Suite 400, Ottawa, Ontario, Canada, K1P
1A4
|
