Re: [eclipselink-dev] EclipseLink OXM Bug 440413

[Marcel Valovy <marcelv3612@xxxxxxxxx>]

Hi David,

Change seems justified to me and patch looks good. I will finish the review in the morning when I run tests on my machine. One thing that can be improved performance-wise is to avoid instanceof and use .getClass() == BigDecimal.class as instanceof traverses the whole inheritance tree.

Best regards

Marcel

On Wed, Sep 30, 2015 at 10:58 PM, David Minsky <david.minsky@xxxxxxxxxx> wrote:

If anybody has literally 5 minutes to spare, would they mind taking a look at the following OXM Bug:

Bug 440413 - XMLConversionManager BigDecimal to xsd:decimal is wrong
https://bugs.eclipse.org/bugs/show_bug.cgi?id=440413

Return a non-scientific notation numeric value String when converting a BigDecimal to a String, using the BigDecimal toPlainString() API. Targeting 2.7.0. test-oxm = 100% pass.

Many thanks in advance,

-David

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev