[eclipselink-dev] bugs 327435, 326799

["Goerler, Adrian" <adrian.goerler@xxxxxxx>]

Hi,

https://bugs.eclipse.org/bugs/show_bug.cgi?id=326799 - skip testLockWithJoinedInheritanceStrategy on MaxDB

Reviewed by Tom.
Tested on MaxDB.
Checked in at 8351.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=327435 - skip check for trailing spaces on MaxDB as MaxDB does not preserve trailing spaces in [VAR]CHAR columns

Reviewed by Tom.
Tested on MaxDB.
Checked in at 8352.

Adrian Görler
SAP AG

Pflichtangaben/Mandatory Disclosure Statements:
http://www.sap.com/company/legal/impressum.epx 

 

> -----Ursprüngliche Nachricht-----
> Von: eclipselink-dev-bounces@xxxxxxxxxxx 
> [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] Im Auftrag von Tom Ware
> Gesendet: Dienstag, 12. Oktober 2010 15:44
> An: Dev mailing list for Eclipse Persistence Services
> Betreff: Re: [eclipselink-dev] bug 326799 - lock 
> (lock.timeout=0) might wait on MaxDB if applied on entities 
> with inheritance type joined
> 
> No objection here.
> 
> Goerler, Adrian wrote:
> > Hi,
> >  
> > I have now attached a patch skipping the test on MaxDB.
> >  
> > Objections if I check this in?
> >  
> > -Adrian
> >  
> > SAP AG
> > Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
> >  
> > Sitz der Gesellschaft/Registered Office: Walldorf, Germany
> > Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo 
> > Apotheker (stellvertretender Sprecher/Deputy CEO), Werner 
> Brandt, Claus 
> > Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
> > Vorsitzender des Aufsichtsrats/Chairperson of the SAP 
> Supervisory Board: 
> > Hasso Plattner
> > Registergericht/Commercial Register Mannheim No HRB 350269
> >  
> >  
> > _____________________________________________
> > *Von:     *Goerler, Adrian 
> > *Gesendet:       *Freitag, 1. Oktober 2010 18:40
> > *An:     *Dev mailing list for Eclipse Persistence Services
> > *Betreff:        *bug 326799 - lock (lock.timeout=0) might 
> wait on MaxDB 
> > if applied on entities with inheritance type joined
> >  
> > Hi all,
> >  
> > _https://bugs.eclipse.org/bugs/show_bug.cgi?id=326799_
> >  
> > what's your opinion on this issue?
> >  
> > In general MaxDB seems to get along well with a lock 
> timeout of 0, which 
> > we can translate to NOWAIT.
> >  
> > However, if applied to an entity with inheritance type 
> JOINED, the lock 
> > NOWAIT fails as two SELECTs - a non-locking-SELECT to determine the 
> > discriminator preceeded by a locking-NOWAIT-SELECT to fetch 
> and lock the 
> > data are executed. The lock method will possibly wait on the first 
> > SELECT. This issue causes the test 
> testLockWithJoinedInheritanceStrategy 
> > to fail.
> >  
> > TestLockWithJoinedInheritanceStrategy is part of the JPA 
> SRG, hence I am 
> > reluctant just to skip it. However, this test (as most of the 
> > pessimistic locking tests) is skipped on
> > isFirebird() || platform.isH2() || platform.isHSQL() || 
> > platform.isAccess() || platform.isSQLAnywhere() || 
> platform.isDerby() || 
> > platform.isPostgreSQL() || platform.isSymfoware())
> >  
> > hence I would not be overly ashamed to skip it on MaxDB as well.
> >  
> >  
> > Would you object if I add a skip for this test on MaxDB?
> >  
> > -Adrian
> >  
> > SAP AG
> > Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
> >  
> > Sitz der Gesellschaft/Registered Office: Walldorf, Germany
> > Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo 
> > Apotheker (stellvertretender Sprecher/Deputy CEO), Werner 
> Brandt, Claus 
> > Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
> > Vorsitzender des Aufsichtsrats/Chairperson of the SAP 
> Supervisory Board: 
> > Hasso Plattner
> > Registergericht/Commercial Register Mannheim No HRB 350269
> >  
> >  
> > 
> > 
> > 
> --------------------------------------------------------------
> ----------
> > 
> > _______________________________________________
> > eclipselink-dev mailing list
> > eclipselink-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>