Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] SVN trunk Commit: Bug# 301599 - avoid m-m join, 228428 , 263302

Revert the m-m id comparison optimization, caused test failure, and fix is more complicated than I realized.

 

 

-----Original Message-----
From: James Sutherland
Sent: Tuesday, August 24, 2010 1:21 PM
To: Eclipselink-Dev@Eclipse. Org (E-mail)
Subject: SVN trunk Commit: Bug# 301599 - avoid m-m join, 228428 , 263302

 

SVN trunk Commit: Bug# 301599 - avoid m-m join

 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=301599

 

Avoid join from m-m join table to target table when only the id is compared.

 

Code review: Andrei

 

Changes:

- Optimize join in RelationExpression normalize for m-m id comparison, also avoid opt for 1-1 if a custom query mapping.

- Some micro opt, remvoed some dead code.

- Made ReadObjectQuery cache check only check the local unit of work cache, as the session cache is checked separately and was being checked twice.

- Changed AbstractDirectMapping to check for null and equality first to handle serialized objects correctly.

- Changed AbstractTransformationMapping

-- use List instead of Vector

-- fixed usage of indirection

-- mutable checks

-- compare byte arrays correctly

-- some cleanup, overrides

-- Avoid conforming in queries if the unit of work is empty.

-- Test for m-m join optimization.

 

Back to the top