Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] running JPA JUnit tests 
Hi Dies,
I am checking in fixes for the initial set of 4 bugs and the issues you mentioned with the Table creators. 

  I'll try to get to some feedback about other items as soon as time allows.

-Tom

Dies Koper wrote:

Hi Tom,
I have solved a few more issues with my DB set-up, platform class and the JUnit tests, and currently have a JUnit success rate of 52% (not counting a few tests I have commented out for now). 

One issue I'd like to ask you about is the following:
/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/relationships/Lego.java
@GeneratedValue(strategy=TABLE, generator="MANUFACTURER_TABLE_GENERATOR") 
    @TableGenerator(
        name="MANUFACTURER_GENERATOR_TABLE",
The generator name in the first annotation is different from the name of the generator defined in the second. 

1) Is this on purpose?
2) On my machine this test leads to an SQLException as table sequence is not found (it did a SELECT * FROM SEQUENCE WHERE SEQ_NAME = 'MANUFACTURER_TABLE_GENERATOR'). I added the following to the Symfoware platform class to change the default table sequence to not use a reserved keyword, but apparently it was not picked up for this test. Do I need to change more? 

    @Override
    protected Sequence createPlatformDefaultSequence() {
        return new TableSequence("", "SEQ_GEN_TABLE");
    }

Same happened in the following and a few more.
/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/relationships/MegaBrands.java /eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/fieldaccess/relationships/Customer.java 


1. Quoted Identifiers
- You mentioned quoted identifiers work on Symfoware for reserved words but not spaces 

Correct.
- The way we get around issues with reserved words on other platforms is to quote the words that are causing issues. Hopefully we can do that for the words that are issues on Symfoware as well. - Could you please file a bug containing all the reserved words that are causing issues. I think the list is: LANGUAGE, VALUE, DOMAIN, SEQUENCE. You mentioned that there is a whole list in the various SQL specifications. I assume we only need to fix the ones that are causing you issues at the moment? 

Yes.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=289163


2. Connection issue with Orbit
- I am assuming you have been able to connect given your progress. Let me know if that is an incorrect assumption 

It is correct, on another machine/location I could access it correctly.


3. Bugs 289019-289023.
- I am going to talk to the rest of the team about trying to get solutions for these issues in as soon as we can. The only thing that could get in the way of this is our JPA 2.0 Reference Implementation delivery dates. 

I'd like to send you my initial platform implementation early next week.
I will also send you my changes to common code (creation of indices).
Without these the Symfoware platform class will compile fine, but none of the tests will work, so it would be great if they can be addressed before the JPA 2.0 delivery dates. 


4. Compilation of Eclipse Projects
- It is not clear to me whether this is working for you right now. Are you still having issues? If not, what issues? 

I made some changes and now it's working for me.
I am still curious why I needed to make those changes to make it work for me (especially if you did not need to). See also point 7 below. 


5. Running testing within Eclipse

- It is not clear to me what the issues you are seeing with this are
I think they were all related to 4. (inability to correctly compile the project). They are solved now. 


6. ClassNotFound (PrimitiveType)
- We have a bug related to an accidental dependency on JDK 6. It will be fixed fairly soon. For now, just use JDK 6. - This is probably also the issue with EclipseLink\jpa\plugins\javax.persistence\src\javax\persistence\EntityManagerFactory.java 


Okay.


7. Project not found javax.persistence
- I am not sure where that dependency is coming from. Can you point me at it. 

It is in:
EclipseLink\foundation\eclipselink.core.test\.classpath

I changed it to "javax.persistence 1.99" to make it work.
I imported the projects in the EclipseLink trunk using Eclipse's Import function. I did not import them as PDE's or any special way. Should I have? So some of the project names have a version number in them, like "javax.persistence 1.99". As some dependencies do not include the version number, it thinks the projects are not there. 

Regards,
Dies

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top