Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [eclipselink-dev] Fix for bug 255832

Instances variables in class DateFormatThreadLocal are reused between
thread.

So they should ideally be final and (immutable themselves or thread
safe).

Like private, final variable communicate and protect.

That should be a rule to used in tool like PMD running against
EclipseLink.

-----Original Message-----
From: eclipselink-dev-bounces@xxxxxxxxxxx
[mailto:eclipselink-dev-bounces@xxxxxxxxxxx] On Behalf Of Matt MacIvor
Sent: Wednesday, November 19, 2008 1:14 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: [eclipselink-dev] Fix for bug 255832

A fix has been checked in for bug 255832

https://bugs.eclipse.org/bugs/show_bug.cgi?id=255832

XML conversions for date strings fail when run with multiple threads. 
This was due to a bug in DateFormatThreadLocal that was causing the same

instance of SimpleDateFormat to be used for all threads instead of 
caching a separate instance.

Code Reviewed by: Blaise Doughan

-Matt
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev


Back to the top