Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipselink-dev] Initial patch for bug 238842 - Add support for running JPA tests on WebSphere

On Yiping's behalf, I have checked the initial patch in both the trunk and 1.0.1 branch.
 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=238842
 
Code Reviewed by: Edwin Tang & Gordon Yorke
 
What's in the initial patch?
 
1. Add websphere.properties and websphere.xml under trunk/jpa/eclipselink.jpa.test for WebSphere properties and targets(websphere-install, websphere-start, websphere-setup, websphere-deploy, webshphere-undeploy, websphere-reset, websphere-stop and so on)
2. Create directory websphere under trunk/jpa/eclipselink.jpa.test/resource, and add WebSphere specific jaxp.properties
3. Modify build.xml under trunk/jpa/eclipselink.jpa.test
(1). Add target "detect-os" to determine which type of commands should be executed for WebSphere testing
(2). Add target "create-ejb-stubs" for generating ejb stubs for WebSphere testing
(3). Change <sysproperty key="server.url" value="${server.url}${MODEL_NAME}"/> to <sysproperty key="server.url" value="${server.url}${APP_NAME}"/>, because WebSphere doesn't work with server.url which has application name appended during jndi lookup
(4). Change <copy todir="${env.JAVA_HOME}/jre/lib" file="${eclipselink.jpa.test}/resource/weblogic/jaxp.properties" failonerror="false"/> to <copy todir="${env.JAVA_HOME}/jre/lib" file="${eclipselink.jpa.test}/resource/${server.name}/jaxp.properties" failonerror="false"/>, since WebSphere's jaxp.properties is different from WebLogic's
 
What will be in the second patch?
1. Once the CQ for the jython scripts - configWebSphere.py, installApps.py and unInstallApps.py - go through the process, they will be checked in trunk/jpa/eclipselink.jpa.test/resource/websphere
2. The property was.jython.scripts.dir in websphere.properties will be changed from ../../../extension.lib.external to ./resource/websphere
 

Back to the top