Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipselink-dev] Fix for 210280: spaces in the (un-URL decoded) persistence unit path fails when assertions are enabled

Hi,
	The following fix has been checked in for 210280

https://bugs.eclipse.org/bugs/attachment.cgi?id=106017&action=diff
https://bugs.eclipse.org/bugs/show_bug.cgi?id=210280

	Details:
		By default we are running with assertions off (-da) - thanks Gordon.  A customer is evidently running with assertions on (-ea) and file existence assertion was failing on a check that does not work with encoded %20 spaces.  We did not fail because the assert check was ignored.  The fix is to decode the path but this isFile() existence check is not required here and will be removed.

	Reproduction:
-------------------
	Turn assertions ON for the JVM and run a JPA SE test where persistence.xml is in a path with spaces (encoded as %20)
		-ea:org.eclipse.persistence
	
	Workaround:
-------------------
	Add the following JVM switch to your launch configuration (the ... at the end is required to disable on subpackages)

		-da:org.eclipse.persistence...

	see:
	http://java.sun.com/javase/6/docs/technotes/tools/windows/java.html


	Code Reviewed
		Gordon - thanks for finding the fact that we running with assertions disabled.

	Testing: with assertions disabled by default
		org.eclipse.persistence.* compile check OK
		test-jpa, test-core OK

Sending content: view_w34b\jpa\org.eclipse.persistence.jpa\src\org\eclipse\persistence\internal\jpa\deployment\PersistenceUnitProcessor.java  
Completed: At revision: 1765  

	thank you
	/michael


Back to the top