Re: [eclipselink-dev] Re: Proposed patch for bug 224964

["Andrei Ilitchev" <andrei.ilitchev@xxxxxxxxxx>]

Yesterday I overrode by accident 
trunk\jpa\eclipselink.jpa.test\test.properties - reverted back.
----- Original Message ----- 
From: "Andrei Ilitchev" <andrei.ilitchev@xxxxxxxxxx>
To: "Dev mailing list for Eclipse Persistence Services" 
<eclipselink-dev@xxxxxxxxxxx>
Sent: Monday, June 02, 2008 2:01 PM
Subject: Re: [eclipselink-dev] Re: Proposed patch for bug 224964


> Checked in a small patch that follows James's suggestion to move
> create/removeCustomizer into connect/disconnect of DatasourceAccessor.
> ----- Original Message ----- 
> From: "Andrei Ilitchev" <andrei.ilitchev@xxxxxxxxxx>
> To: "Dev mailing list for Eclipse Persistence Services" 
> <eclipselink-dev@xxxxxxxxxxx>
> Sent: Friday, May 30, 2008 4:48 PM
> Subject: Re: [eclipselink-dev] Re: Proposed patch for bug 224964
>
>
> > Based on Edwin's freedback added a new small testing patch (attached to 
> > the bug) to be applied on to of the previous ones.
> > ----- Original Message ----- 
> > From: "Andrei Ilitchev" <andrei.ilitchev@xxxxxxxxxx>
> > To: "Dev mailing list for Eclipse Persistence Services" 
> > <eclipselink-dev@xxxxxxxxxxx>
> > Sent: Thursday, May 29, 2008 4:33 PM
> > Subject: Re: [eclipselink-dev] Re: Proposed patch for bug 224964
> >
> >
> > > Based on feedback frrom James and Edwin a new small patch (attached to 
> > > the bug) was applied on top of the previous one:
> > > 1) Cleaned up some comments in PersistenceUnitProperties and 
> > > EntityManagerProperties;
> > > 2) Moved Oracle-specific JPA tests from FullRegressionTestSuite to the 
> > > newly created OracleJPATeatSuite.
> > >
> > > ----- Original Message ----- 
> > > From: "Andrei Ilitchev" <andrei.ilitchev@xxxxxxxxxx>
> > > To: "Dev mailing list for Eclipse Persistence Services" 
> > > <eclipselink-dev@xxxxxxxxxxx>
> > > Sent: Thursday, May 29, 2008 9:44 AM
> > > Subject: Re: [eclipselink-dev] Re: Proposed patch for bug 224964
> > >
> > >
> > > > The main part was reviewed by James some time ago, some other fixes 
> > > > were discussed before checking in with you and Gordon.
> > > > I will ask James to take a look at the whole thing.
> > > > ----- Original Message ----- 
> > > > From: "Tom Ware" <tom.ware@xxxxxxxxxx>
> > > > To: "Dev mailing list for Eclipse Persistence Services" 
> > > > <eclipselink-dev@xxxxxxxxxxx>
> > > > Sent: Thursday, May 29, 2008 8:45 AM
> > > > Subject: Re: [eclipselink-dev] Re: Proposed patch for bug 224964
> > > >
> > > >
> > > > > Who reviewed this?
> > > > >
> > > > > Andrei Ilitchev wrote:
> > > > > > Checked in.
> > > > > > ----- Original Message ----- From: "Andrei Ilitchev" 
> > > > > > <andrei.ilitchev@xxxxxxxxxx>
> > > > > > To: "Dev mailing list for Eclipse Persistence Services" 
> > > > > > <eclipselink-dev@xxxxxxxxxxx>
> > > > > > Sent: Wednesday, May 28, 2008 2:12 PM
> > > > > > Subject: Re: Proposed patch for bug 224964
> > > > > >
> > > > > >
> > > > > > > Forgot to mention that the patch is attached to 
> > > > > > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=224964
> > > > > > > ----- Original Message ----- From: "Andrei Ilitchev" 
> > > > > > > <andrei.ilitchev@xxxxxxxxxx>
> > > > > > > To: "Dev mailing list for Eclipse Persistence Services" 
> > > > > > > <eclipselink-dev@xxxxxxxxxxx>
> > > > > > > Sent: Wednesday, May 28, 2008 2:09 PM
> > > > > > > Subject: Re: Proposed patch for bug 224964
> > > > > > >
> > > > > > >
> > > > > > > > I am about to check in the patch for bug 224964: Provide support 
> > > > > > > > for Proxy Authentication through JPA
> > > > > > > >
> > > > > > > > It provides support for Oracle PA using openProxySession (both JPA 
> > > > > > > > and core) in all cases (including ExclusiveIsolatedClientSession);
> > > > > > > > Adds JPA property for specifying ExclusiveIsolatedClientSession (at 
> > > > > > > > least one descriptor must be isolated);
> > > > > > > > Cleans up PropertiesHandler;
> > > > > > > > EntityManagerProperties reuses names defined in 
> > > > > > > > PersistenceUnitPrioperties;
> > > > > > > > Modifies uow to allow to instantiate ValueHolder when dead;
> > > > > > > > Uow always released when em.close called (unless there's active 
> > > > > > > > trans - then it released when transaction is completed);
> > > > > > > > RepeatbleWriteUow.release method releases change sets but not the 
> > > > > > > > cache.
> > > > > > > > Usage of ExclusiveIsolatedClientSession should not cause connection 
> > > > > > > > leakage (provided that in JTA case the session is released by the 
> > > > > > > > user (core case) or em is closed (jpa case);
> > > > > > > > Modified ExclusiveIsolatedClientSession not to through exception in 
> > > > > > > > case it instatiates ValueHolder for Isolated class while already 
> > > > > > > > been released - instead the new connection will be acquired and 
> > > > > > > > kept just for the duration of the query;
> > > > > > > > Modified emSetupImpl so that listener passed to createEMF is 
> > > > > > > > actually used;
> > > > > > > > Partially fixed partially worked around 
> > > > > > > > "java.lang.OutOfMemoryError: PermGen space" error that shows up in 
> > > > > > > > case of open/close the same factory many times, see the big comment 
> > > > > > > > in EntityManagerSetupImpl.predeploy method.
> > > > > > > >
> > > > > > > > Also:
> > > > > > > > Removes the old code that supported openProxySession - based 
> > > > > > > > ProxyAuthentication, but the old code for OCI-based PA is kept 
> > > > > > > > (it's not covered by the new code).
> > > > > > > >
> > > > > > > > Tests:
> > > > > > > > jpa: FullRegressionTestSuite -> ProxyAuthenticationTestSuite
> > > > > > > > core:  OracleModel -> ProxyAuthenticationCustomizerTestModel
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Andrei.
> > > > > >
> > > > > > _______________________________________________
> > > > > > eclipselink-dev mailing list
> > > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > > > _______________________________________________
> > > > > eclipselink-dev mailing list
> > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > >
> > > _______________________________________________
> > > eclipselink-dev mailing list
> > > eclipselink-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> >
> > _______________________________________________
> > eclipselink-dev mailing list
> > eclipselink-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev