Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [eclipselink-dev] proposed patch for bug 227766 - Need to migrate TopLink integration tests with Spring to EclipseLink
I have revised the patch based on the feedback.

- check the tests into directory trunk/jpa/eclipselink.jpa.spring.test
- add the eclipse license header in all java files
- clean up
- create an Eclipse project for the tests
- create target test-jpa-spring in the top level Ant project in trunk
- replace tabs with spaces in code


-----Original Message-----
From: DOUGLAS.CLARKE@xxxxxxxxxx 
Sent: May 28, 2008 10:33 AM
To: TOM.WARE@xxxxxxxxxx; EDWIN.TANG@xxxxxxxxxx; ERIC.GWIN@xxxxxxxxxx
Cc: PETER.KROGH@xxxxxxxxxx
Subject: RE: [eclipselink-dev] proposed patch for bug 227766 - Need to
migrate TopLink integration tests with Spring to EclipseLink

A CQ is only required if the source was written elsewhere and being contributed. If a committer writes it for EclipseLink then the 250 lines does not apply. If it is written by a contributor the 250 lines does apply.


-----Original Message-----
From: TOM.WARE@xxxxxxxxxx 
Sent: Wednesday, May 28, 2008 9:01 AM
To: EDWIN.TANG@xxxxxxxxxx; DOUGLAS.CLARKE@xxxxxxxxxx;
Subject: Re: [eclipselink-dev] proposed patch for bug 227766 - Need to
migrate TopLink integration tests with Spring to EclipseLink

2 comments that Doug may have feedback about
- Your current name is eclipselink.spring.test.  Since these are JPA tests, 
should we call them eclpselink.jpa.spring.test?
- I forget.... Is there a CQ for this stuff already.  If not, we will need one 
since it is over the 250 line limit.

- Please make sure Eric reviews the build files

Some other comments:

- The java files all need the eclipse license header.  You should be able to get 
it from any of the other checked in files
- I'm a little concerned about duplicating the file.  Is 
everything in there needed by the spring tests?
- Our other components have an Eclipse project and Run targets checked in as 
well so people can easily access them out of Eclipse.  We should add those
- Some of the files have tab characters.  Our coding standard dictates that we 
only use spacess.  (4 spaces instead of a tab)


EDWIN.TANG@xxxxxxxxxx wrote:
> This proposed patch creates directory eclipselink.spring.test under 
> trunk/jpa to accommondate the Spring tests. The previous patch was 
> checked in and then rolled back because the tests were put in 
> trunk/jpa/eclipselink.jpa.test and resulted in complier errors in 
> exsiting Eclipse project - eclipselink.jpa.test.
> *Change Summary:*
> - Create directory eclipselink.spring.test under trunk/jpa
> - Migrate TopLink/Spring testing source and resource files to EclipseLink
> - From trunk/jpa/eclipselink.spring.test, executing "ant", "ant 
> test-spring-local" and "ant test-spring-container" will build and run 
> the tests respectively
> - To build and run the tests, the following third-party jars are 
> required in ../../../extension.lib.external/spring
>  * spring.jar(version 2.5.3)
>  * spring-agent.jar(version 2.5.3)
>  * spring-mock.jar(version 2.5.3)
>  * cglib-nodep-2.2.jar
>  * commons-logging-1.1.1.jar
> Test Results:
> ------------------------------------------------------------------------
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx

Back to the top