[eclipselink-dev] [Fwd: Code review of 221873 files...]

[Eric Gwin <eric.gwin@xxxxxxxxxx>]

I am resending again (first attempt was bounced).

-------- Original Message --------
Subject: 	Code review of 221873 files...
Date: 	Wed, 30 Apr 2008 11:09:14 -0400
From: 	Eric Gwin <eric.gwin@xxxxxxxxxx>
Organization: 	Oracle Corporation
To: 	eclipselink-dev@xxxxxxxxxxx



All,

I have been working on an automated system for the eclipselink 
continuous and nightly builds, and I'd like to have it reviewed before I 
submit it as ready for "prime-time".  Your comments are appreciated.

The goals of the design of the system were:
-reduce the number of files that need to be maintained.
-incorporate the system into version control
-enable the system to be run from version control
-enable the system to build any "branch"

I have considered laying down 'failsafe' or flag files (to alert the 
system that "x" target is currently being run), but with the existing 
cron setup it isn't needed. Doing so would allow an "anytime" cron setup. 

I believe any automated system should also be able to duplicate any 
build on any branch, but I am uncertain of the desirability for this 
project. Comments would be appreciated.

Also, the bootstrap files should be flexible enough to handle unforeseen 
circumstances, and remain unmodified (because it should work for any 
branch). Therefore, I've been toying with the notion of splitting away 
the env settings, but am caught between the need to keep the main 
scripts unmodified, and the goal of reducing the file set. Setting the
env could be documented as a mandatory initial step to setting up the
system.

Currently the system consists of:
trunk/autobuild.xml
trunk/autobuild.propertiees
trunk/buildsystem/bootstrap.sh
trunk/buildsystem/bootstrap.xml

- bootstrap.sh verifies the environment, sets appropriate env variables 
and invokes ANT using bootstrap.xml to get the branch source, and then 
call autobuild.xml
- autobuild gets any dependent libraries, and in the case of the "cb", 
it tests for newly committed files, then calls the trunk build targets 
(trunk/build.xml).
- autobuild currently depends upon two scripts in buildsystem for the 
nightly builds, the plan being to bring that functionality into 
autobuild ASAP. All other scripts and the current build.xml and 
build.properties files will be removed from the buildsystem directory.


Thanks.

-Eric