Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [] Automating quality gates on contribution: Copyright header

While I do see value in this proposal I'm not confident that the ECA check tool is the right candidate for this (implementing too many concerns in that app).

Wouldn't it be better to use existing tools/plug-ins, which already do these kind of checks and publish pom.xml blueprints for Maven/Tycho based projects? Seems like an easier way to implement.


Gunnar Wagenknecht

On Feb 2, 2020, at 18:39, Mickael Istria <mistria@xxxxxxxxxx> wrote:

Hi all,

I had the opportunity to attend FOSDEM and see a talk about dependency management by Jeff McCaffer, mentioning among others ClearlyDefined.
Then the discussion went more into the best practices to get high quality Open-Source software and community. Not so surprisingly, one key point is automation of quality checks during reviews, and the licensing of files was mentioned as a quality criterion.
So I think to improve a bit our practices with an easily executable change, the ECA check that runs on Gerrit review and GitHub PRs should also check the added text file have a copyright header, and report an helpful error otherwise:


Mickael Istria
Eclipse IDE developer, for Red Hat Developers
_______________________________________________ mailing list

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

Back to the top