| 
Hi Andrey,   Please contribute this fix to R4_23_maintenance branch and let me know. Master has been moved to 4.24. RC2a will be built from R4_23_maintenance branch
   Thanks Sravan   
From: eclipse-pmc <eclipse-pmc-bounces@xxxxxxxxxxx>
On Behalf Of Thomas WatsonSent: 07 March 2022 22:36
 To: eclipse-pmc@xxxxxxxxxxx
 Subject: [EXTERNAL] Re: [eclipse-pmc] 4.23 RC2a request for MAT / bug 579119
   ZjQcmQRYFpfptBannerStart
 
| 
| 
| This Message Is From an External Sender
 |  
| This message came from outside your organization.
 |  |  |  ZjQcmQRYFpfptBannerEnd
 
 
+1 from me.  The issue seems severe enough to consider for RC2a 
 
 
ZjQcmQRYFpfptBannerStart
 
This Message Is From an External Sender
 
This message came from outside your organization.
 ZjQcmQRYFpfptBannerEnd
 
 
  
Change looks good to me.  If I understand correctly, it simply limits the display of the dialog to be only when the user has checked the box "For not listed types, prompt for editor if size exceeds:
 ..." 
"concern from releng side that RC2 EPP packages are not published so changes may not get enough exposure." 
Is this a concern for all changes that went into RC2, let alone RC2a?  Is this change any more risking from that point of view than the other fixes that went into RC2? 
It's a bit more of a concern due to time limitation and less people expecting RC2a, looking for it or even having time thus not downloading our build.
 
Can we count this one as "go" from you, Tom? 
 
 
On Mon, Mar 7, 2022 at 11:10 AM Andrey Loskutov <loskutov@xxxxxx> wrote: Sure, gerrit patch is linked to the bug:
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191527 The change looks good to me but there is concern from ZjQcmQRYFpfptBannerStart
 
This Message Is From an External Sender
 
This message came from outside your organization.
 ZjQcmQRYFpfptBannerEnd
 
 
  
Sure, gerrit patch is linked to the bug: 
The change looks good to me but there is concern from releng side that RC2 EPP packages are not published so changes may not get enough exposure. I would like to hear from at least one more PMC member before give this one a go. 
_______________________________________________eclipse-pmc mailing list
 eclipse-pmc@xxxxxxxxxxx
 To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
 
 --
 _______________________________________________eclipse-pmc mailing list
 eclipse-pmc@xxxxxxxxxxx
 To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
 
 --
 |