There are few points to be considered - 1. Problem is not with the trivial code changes, problem is in managing
the merge conflicts either during this mass change by the contributor or
by other contributors after this mass change is released. (As I have seen
it happening this week where contributor is struggling to rebase the mass
change gerrits) 2. This merging turns to be an evil specially for JDT repositories where
new Java version work happens in a different branch (due to legal constraints).
I am OK with the mass changes in M1 but it should be a call of the component
based on the timeline and other feature development going on in parallel
Thanks & Regards, Sarika
---06/20/2019 06:01:32 AM---Thanks Mickael, that's a good approach which
works fine with me. As for the review, yes a second per
Thanks Mickael, that's a good approach which works fine with me.
As for the review, yes a second person besides the owner must give a code-review+1
(or+2), but for mass changes with (apparently) trivial code changes I would
be OK if only random samples are reviewed.
About !longChain.isEmpty() vs longChain.size() > 0, I favor the first
one because isEmpty() is theorically a O(1) operation while size() is a
O(n). Of course, most of smart enough implementations have this optimized
and make size() a O(1), but there is usually no guarantee it is so. So
size() is more expensive that isEmpty() and should be preferred. About readability, I understand the concern and I would like to suggest
an alternative for that case: longChain.isEmpty() == false, which seems
to have the qualities requested by all parties.
About requiring a review for mass changes, +1. About not allowing mass change after some milestone, +1.
-- Eclipse Platform project co-lead CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg Amtsgericht Hamburg: HRB 127058 Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel USt-IdNr.: DE284122352 Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx,
"noname" deleted by Daniel Megert/Zurich/IBM] _______________________________________________ eclipse-pmc mailing list eclipse-pmc@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe
from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-pmc