[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [eclipse-pmc] Review of mass changes
- From: Mickael Istria <mistria@xxxxxxxxxx>
- Date: Wed, 19 Jun 2019 18:47:32 +0200
- Delivered-to: firstname.lastname@example.org
My 2c below ;)
About !longChain.isEmpty() vs longChain.size() > 0, I favor the first one because isEmpty() is theorically a O(1) operation while size() is a O(n). Of course, most of smart enough implementations have this optimized and make size() a O(1), but there is usually no guarantee it is so. So size() is more expensive that isEmpty() and should be preferred.
About readability, I understand the concern and I would like to suggest an alternative for that case: longChain.isEmpty() == false, which seems to have the qualities requested by all parties.
About requiring a review for mass changes, +1.
About not allowing mass change after some milestone, +1.