> And the changes that followed were only possible after those cleanups in place.
> I've prepared the code to be able to read and debug it, which both were hardly doable before.
Andrey, thanks for the clarification. That is exactly what it meant. I never implied that your initial cleanup work was useless or not focused.
Developers have different reasons why cleanup work is important to them, some prepare big fixes as you did, others just what to reduce the number of warnings in the code, others want to reduce Sonar warnings, some cleanup the code basis to make it more attractive to new developers, etc.
Therefore, I strongly believe this work is important for the project.
Best regards, Lars
Am Do., 15. Nov. 2018, 16:45 hat Andrey Loskutov <
loskutov@xxxxxx> geschrieben:
> Cleanup work is usually important for new contributors. When you
> started to contribute to platform UI most all of your first 10
> contributions were cleanup commits.
> Some of them affected highly the
> Git blame functionality.
CPD code was in a horrible state after transition from 3.x to 4.x, which made all of this code *non functional*.
Additionally to that, one couldn't literally read the code because it was all yellow from warnings.
So before doing anything meaningful to restore broken functionality I had literally to cleanup all the mess.
The changes you are pointing were also not just cleanup because of Sonar wanted it, but because I've transformed the code to a clean state *before* doing *heavy* functional changes.
And the changes that followed were only possible after those cleanups in place.
> See
> https://git.eclipse.org/r/#/q/owner:loskutov%2540gmx.de+status:merged+project:platform/eclipse.platform.ui,410
> for the list and
> https://git.eclipse.org/r/#/c/38634/13/bundles/org.eclipse.ui.workbench/Eclipse+UI/org/eclipse/ui/internal/Perspective.java
> for one of your changes. In this phase, I reviewed and accepted your
> patches despite the feedback that this would be bad for comparison
> (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=456729#c4 for such
> a comment). It is hard to say, what would happen if your cleanup
> patches were rejected but I assume your desire to contribute would
> have been negatively impacted by this.
There were good reasons not to reject those patches: the major functionality loss we had at that time. And I have no problems to have patches rejected if there is a good reason for that.
> Now you are one of our best
> developers. And you started with cleanup work.
Not true, I've started with fixing REAL bug, broken CPD. You see commit by commit that I've prepared the code to be able to read and debug it, which both were hardly doable before.
Regards,
Andrey
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
