Re: [eclipse-pmc] Request to backport Bug 495567 - Properties view shows

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

Hi Andrey

This change is not good - also not for
master. The API class 'PropertySheet'
leaks internal stuff from 'ISecondarySaveableSource'.
An API must not inherit from or implement internal types.

The Javadoc for 'PropertySheet#isDirtyStateSupported()'
is wrong:
@returnreturns {@code false} by default.
The method does not return 'false',
hence the Javadoc must describe what is returned.

Please revert the changes in the maintenance
branch and fix the code in master. After that, you may file a new request
for backporting, which contains a Gerrit change for review.

Dani



From:      
 "Andrey Loskutov"
<loskutov@xxxxxx>
To:      
 pmc <eclipse-pmc@xxxxxxxxxxx>
Date:      
 09.08.2016 18:19
Subject:    
   [eclipse-pmc]
Request to backport Bug 495567 - Properties view shows a "dirty"
state
Sent by:    
   eclipse-pmc-bounces@xxxxxxxxxxx

---

Hi all,

To fix bug 495567 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=495567)
the new API was added in 4.7: 

protected boolean org.eclipse.ui.views.properties.PropertySheet.isDirtyStateSupported().

The new method is not abstract, and the PropertySheet class is not intended
to be extended (@noextend), so it should not break client code for "good"
clients.

There is a small chance that someone extended this class (1) and implemented
same method with the similar signature (2), which would break that client.
Practically, I don't think that conditions 1&2 have significant probability
to appear at same time.

Since the bug itself is annoying for clients of the Properties view, I
would like to request the approval from PMC to backport this fix to 4.6.x
stream.

The patch consists of two parts: https://git.eclipse.org/r/77035and https://git.eclipse.org/r/#/c/77036/.
The second part introduces API change.

Please note, that by my fault, I've overseen that I've introduced new API
to PropertySheet and we've already merged the patch to R4_6_maintenance.

Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc