Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request to backport Bug 495567 - Properties view shows a "dirty" state

Hi Andrey

This change is not good - also not for master. The API class 'PropertySheet' leaks internal stuff from 'ISecondarySaveableSource'. An API must not inherit from or implement internal types.

The Javadoc for 'PropertySheet#isDirtyStateSupported()' is wrong:
@returnreturns {@code false} by default.
The method does not return 'false', hence the Javadoc must describe what is returned.

Please revert the changes in the maintenance branch and fix the code in master. After that, you may file a new request for backporting, which contains a Gerrit change for review.


From:        "Andrey Loskutov" <loskutov@xxxxxx>
To:        pmc <eclipse-pmc@xxxxxxxxxxx>
Date:        09.08.2016 18:19
Subject:        [eclipse-pmc] Request to backport Bug 495567 - Properties view shows a "dirty" state
Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx

Hi all,

To fix bug 495567 ( the new API was added in 4.7:

protected boolean

The new method is not abstract, and the PropertySheet class is not intended to be extended (@noextend), so it should not break client code for "good" clients.

There is a small chance that someone extended this class (1) and implemented same method with the similar signature (2), which would break that client. Practically, I don't think that conditions 1&2 have significant probability to appear at same time.

Since the bug itself is annoying for clients of the Properties view, I would like to request the approval from PMC to backport this fix to 4.6.x stream.

The patch consists of two parts: The second part introduces API change.

Please note, that by my fault, I've overseen that I've introduced new API to PropertySheet and we've already merged the patch to R4_6_maintenance.

Kind regards,
Andrey Loskutov
eclipse-pmc mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top