Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] New API for 4.4.2 - approval request

Good points Martin. Some clarifications/additions:

One can have many fast views (or minimized in new terminology) that might never be used during a session. Therefore they don't need to be created and their input loaded, and since this happens during startup, the benefit of this fix can be huge. I verified that the fix works.

Daniel, it looks that what you test/add here is 'org.eclipse.e4.ui.internal.workbench.swt.CSSConstants.CSS_ACTIVE_CLASS' ("active"). So, in order to be correct, you need to use the new constant in 'org.eclipse.e4.ui.workbench.renderers.swt', and any other places where applicable.

I suggest you prepare a new fix. Backporting is a good idea, and I'm in favor of using one single constant rather than strings distributed over several plug-ins.


From:        "Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>
To:        "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>, "daniel.rolka@xxxxxxxxx" <daniel.rolka@xxxxxxxxx>
Date:        09.11.2014 03:04
Subject:        Re: [eclipse-pmc] New API for 4.4.2 - approval request
Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx

Hi Daniel,
I have only looked at the changeset that was intended to be backported, and I have some questions:
1.       Why is a backport necessary in the first place ? – On a cursory review this looks like only a performance optimization to me, at least the bug doesn’t clearly say what is the end user’s visible effect of the problem and why the backport is necessary. Or have I overlooked the problem description ?

2.       In the changeset, the new API constant ACTIVE is used only for reading state, but it looks like that state is never written. How is that supposed to work ?

3.       The new API constant is only a String. If the result of question #1 above is that a backport is necessary, why does the new API have to be exposed ? Why can’t the internal code which uses this String just use the String constant “active” instead ?
Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River
direct +43.662.457915.85  fax +43.662.457915.6
From: eclipse-pmc-bounces@xxxxxxxxxxx [mailto:eclipse-pmc-bounces@xxxxxxxxxxx] On Behalf Of Daniel Rolka
Friday, November 07, 2014 1:22 PM
[eclipse-pmc] New API for 4.4.2 - approval request


I would like to back port the following patch to 4.4.2 - and

The patch appends the new constant that is new API for 4.4.2. Can I go with this patch for 4.4.2? Can I also add proper filter for the API tooling that will disable the warning connected to the new API?

eclipse-pmc mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top