Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] API addition for org.eclipse.team.core.history.IFileRevision

Obviously +1 from me ;-)

Olexiy worked hard with us on this and it would be ugly if we slip 3.7. 
Seeing the branches in the History view is a valuable addition, especially 
when working in different branches.

Dani


From:
Tomasz Zarna <TomaszZarna@xxxxxxxxxx>
To:
eclipse-pmc@xxxxxxxxxxx
Date:
17.03.2011 12:09
Subject:
[eclipse-pmc] API addition for org.eclipse.team.core.history.IFileRevision




GOALS/BENEFITS:
A new column for branches in CVS History view requires a list of branch
names of a file revision. So the requested API is getBranches() on
org.eclipse.team.core.history.IFileRevision. This interface is not 
intended
to be implemented by clients, so we're safe here. However, clients can
extend the abstract org.eclipse.team.core.history.provider.FileRevision
class, so we provide a default implementation that returns an empty array.
For more details see bug 76386.

We (Dani and myself) invested a lot time together with Olexiy on that fix,
it's well tested, we just slipped M6.

AFFECTED BUGS:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=76386

RISKS:
No known risks. A potential client won't get the new column for free, he
will have to override getBranches() method in his implementation of
IFileRevision (subclass of FileRevision). Otherwise he will get an empty
column *if* he decides to show it in the UI.

PERFORMANCE IMPACTS:
Should not have an impact.
--
Tomasz Zarna

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc





Back to the top