Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] API change request: Deprecated API removal

+1, since the offending API also had been documented as: "@deprecated use
dragDetect(Event) - This API was added between 3.2 and 3.3, and will be
removed for 3.3."

(thanks Jerome for observing it)



                                                                           
             Steve Northover                                               
             <Steve_Northover@                                             
             ca.ibm.com>                                                To 
             Sent by:                  eclipse-pmc@xxxxxxxxxxx             
             eclipse-pmc-bounc                                          cc 
             es@xxxxxxxxxxx                                                
                                                                   Subject 
                                       Re: [eclipse-pmc] API change        
             03/27/2007 11:32          request: Deprecated API removal     
             PM                                                            
                                                                           
                                                                           
             Please respond to                                             
             eclipse-pmc@eclip                                             
                  se.org                                                   
                                                                           
                                                                           





I've checked on the cross-project-issues-dev mailing list and GEF, GMF and
WTP aren't using it.  I'm sure we are safe to take it out.


                                                                           
 Mike                                                                      
 Wilson/Ottawa/IBM@IBMCA                                                   
 Sent by:                                                               To 
 eclipse-pmc-bounces@eclipse           eclipse-pmc@xxxxxxxxxxx             
 .org                                                                   cc 
                                                                           
                                                                   Subject 
 03/27/2007 09:42 AM                   Re: [eclipse-pmc] API change        
                                       request: Deprecated API removal     
                                                                           
      Please respond to                                                    
   eclipse-pmc@xxxxxxxxxxx                                                 
                                                                           
                                                                           
                                                                           
                                                                           






If you can get to the point where you are confident that this isn't being
used outside the SDK either, then I will withdraw my -1.

McQ.

                                                                           
 Steve                                                                     
 Northover/Ottawa/IBM@IBMCA                                                
 Sent by:                                                                  
 eclipse-pmc-bounces@eclipse                                            To 
 .org                                  eclipse-pmc@xxxxxxxxxxx             
                                                                        cc 
                                                                           
 03/26/07 15:30                                                    Subject 
                                       Re: [eclipse-pmc] API change        
                                       request: Deprecated API removal     
      Please respond to                                                    
         eclipse-pmc                                                       
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           







McQ, I was wondering if you could reconsider.  The plan was always to take
the API out and it was approved on this list on March 19th.

Since we had broken the integration build for M6 that morning, I was afraid
to do it again.  Of course, the next integration build was after the API
was frozen, Doh!  I'm going post on cross-project-issues-dev to see if
anyone is using this API.

Here is the original mail message:

+1

NOTE:  We will deprecate the old API for now and remove it after a
successful integration build.
                                                                           
 Felipe Heidrich/Ottawa/IBM@IBMCA                                          
                                                                           
 Sent by:                                                                  
 eclipse-pmc-bounces@xxxxxxxxxxx                                           
                                                                        To 
                                             eclipse-pmc@xxxxxxxxxxx       
 03/19/2007 04:44 PM                                                    cc 
                                                                           
                                                                   Subject 
                                             [eclipse-pmc] new API         
         Please respond to                   required to fix Bug 177927    
      eclipse-pmc@xxxxxxxxxxx                                              
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           








I'll need new API to fix Bug 177927.
For the fix I need to change StyledText to use the new API
Control#dragDetect.
I also need to extent this API in control to take the click count.

Remove from Control
public boolean dragDetect (int button, int stateMask, int x, int y)
Note: Control.dragDetect(int, int, int, int) was new API for Eclipse 3.3

Add to Control
public boolean dragDetect (Event event)
public boolean dragDetect (MouseEvent event)

Thanks
Felipe
                                                                           
 Mike                                                                      
 Wilson/Ottawa/IBM@IBMCA                                                   
 Sent by:                                                                  
 eclipse-pmc-bounces@eclipse                                            To 
 .org                                  eclipse-pmc@xxxxxxxxxxx             
                                                                        cc 
                                                                           
 03/26/2007 03:18 PM                                               Subject 
                                       Re: [eclipse-pmc] API change        
                                       request: Deprecated API removal     
      Please respond to                                                    
   eclipse-pmc@xxxxxxxxxxx                                                 
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           







-1.

McQ.
                                                                           
 Carolyn                                                                   
 MacLeod/Ottawa/IBM@IBMCA                                                  
 Sent by:                                                                  
 eclipse-pmc-bounces@eclipse.                                           To 
 org                                    eclipse-pmc@xxxxxxxxxxx            
                                                                        cc 
                                                                           
 03/26/07 13:47                                                    Subject 
                                        [eclipse-pmc] API change request:  
                                        Deprecated API removal             
       Please respond to                                                   
          eclipse-pmc                                                      
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           








The following method was added after 3.2 and is no longer needed:
org.eclipse.swt.widgets.Control.dragDetect(int, int, int, int)

It was deprecated but we left it in so as not to burn M6.
Request for permission to delete it now.

GOALS/BENEFITS:
Avoid growing API with an unneeded method.

CORRESPONDING BUG:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=170849

RISKS:
No risk since this method didn't exist in 3.2 and we checked that no
references to this method exist in the Eclipse SDK.

PERFORMANCE IMPACTS:
None._______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc




Back to the top