[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-dev] [jdt-dev] Automate check to warn about freeze on Gerrit
|
> I’d argue that we only really need the comment to be added if we’re in a freeze.
+1
On Tue, Dec 15, 2020 at 3:53 PM Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
>
> On 14 Dec 2020, at 08:48, Mickael Istria <mistria@xxxxxxxxxx> wrote:
>
>
>
> On Mon, Dec 14, 2020 at 9:36 AM Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:
>>
>> Yes That is correct. In my opinion getting a +1 from platform bot before the actual gerrit job is confusing. Is it possible not to give +1 but give -1 in case of freeze period?
>
>
> OK, I'm changing that.
>
>
> I saw a comment on a recent change:
>
> https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/173651
>
> Build Started https://ci.eclipse.org/platform/job/Report-freeze-dates-to-Gerrit/148/ Checking whether Eclipse project is currently in stabilitzation/code-freeze period
> Checking whether Eclipse project is currently in stabilitzation/code-freeze period
> hecking whether Eclipse project is currently in stabilitzation/code-freeze period…
>
> Build Successful
> https://ci.eclipse.org/platform/job/Report-freeze-dates-to-Gerrit/148/ : Eclipse project is currently not in a code-freeze period. You can merge today if the change meets all other merge criteria.
>
> Can we have the bot not comment if we’re not in a change?
> https://ci.eclipse.org/platform/job/Report-freeze-dates-to-Gerrit/148/ : Eclipse project is currently not in a code-freeze period. You can merge today if the change meets all other merge criteria.
>
>
> Can we have the bot not comment if we’re not in a change freeze, which will be most of the time? We don’t really need to know that the ‘check freeze’ bot has started, nor if it isn’t a freeze … I’d argue that we only really need the comment to be added iff we’re in a freeze.
>
> Alex
> _______________________________________________
> eclipse-dev mailing list
> eclipse-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
