Re: [eclipse-dev] API Change in org.eclipse.ui.internal.EditorSite, How

[Eric Moffatt <emoffatt@xxxxxxxxxx>]

Susinda, what I was trying to ask was 'What does MyEditorSite do *different* than a regular site ?'. I'm trying to see whether using the new e4-based API we can accomplish the same thing *without* you having to subclass EditorSite (which is a hack because it's an 'internal' class).

Eric


Susinda ---04/08/2014 08:02:47 AM---Hi Eric In eclipse 3.7 implementation i could create a editorsite by extending

From:	Susinda <susinda@xxxxxxxxx>
To:	"General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>,
Date:	04/08/2014 08:02 AM
Subject:	Re: [eclipse-dev] API Change in org.eclipse.ui.internal.EditorSite, How to migrate to newer
Sent by:	eclipse-dev-bounces@xxxxxxxxxxx

---

Hi Eric

In eclipse 3.7 implementation i could create a editorsite by extending EditorSite like follows

public class MyEditorSite extends EditorSite {
And could instantiate using following parameters
IEditorReference ref, IEditorPart editor, WorkbenchPage page, EditorDescriptor desc
EditorSite site = new MyEditorSite(ref, editor, page, desc);

But in 4.3 this is not allowed. It says Discouraged access: The type EditorSite is not accessible due to restriction on required .... org.eclipse.ui.workbench_3.105.2.v20140211-1711.jar

The question i have is how can i convert 3.7 implementation of MyEditorSite, to 4.3 implementation.
Can we instantiate an EditorSite in 4.3 or it is discouraged to do so? If so what is the best practice or what is the alternative for this.

Thanks

Susinda



On Mon, Apr 7, 2014 at 8:03 PM, Eric Moffatt <emoffatt@xxxxxxxxxx> wrote:

Susinda, perhaps it might be better to explain what the override you were using did (i.e. how does it differ from the IDE's implementation. I ask because we may be able to fix the root issue now rather than making you rely on a 'hack'...

Onwards,
Eric


Susinda ---04/07/2014 08:11:19 AM---Hi All In eclipse 3.7 The constructor of EditorSite was as follows [1]

From:	Susinda <susinda@xxxxxxxxx>
To:	eclipse-dev@xxxxxxxxxxx,
Date:	04/07/2014 08:11 AM
Subject:	[eclipse-dev] API Change in org.eclipse.ui.internal.EditorSite, How to migrate to newer
Sent by:	eclipse-dev-bounces@xxxxxxxxxxx

---





Hi All

In eclipse 3.7 The constructor of EditorSite was as follows [1]
EditorSite(IEditorReference ref, IEditorPart editor, WorkbenchPage page, EditorDescriptor desc)

However in 4.3 It has been changed as follows [2]
EditorSite(MPart model, IWorkbenchPart part, IWorkbenchPartReference ref, IConfigurationElement element)

Because of the above mentioned change i'm facing difficulties on building the BPEL code which uses the earlier (3.7) implementation. And also the full issue is reported under [3], please have a look at to get more details.

Here what i wanted to know is how can i migrate the code to use the newer version (i.e 1.3). How can i create and pass following parameters
MPart model, IWorkbenchPart part, IWorkbenchPartReference ref, IConfigurationElement element

starting from
IEditorReference ref, IEditorPart editor, WorkbenchPage page, EditorDescriptor desc

Your help, advises and thoughts are highly appreciated.

Thanks in advance


[1] - http://grepcode.com/file/repository.grepcode.com/java/eclipse.org/3.7/org.eclipse.ui/workbench/3.7.0/org/eclipse/ui/internal/EditorSite.java
[2] - http://grepcode.com/file/repository.grepcode.com/java/eclipse.org/4.3/org.eclipse.ui/workbench/3.105.0/org/eclipse/ui/internal/EditorSite.java
[3] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=378997

--
**********************************
Susinda Perera
B.Sc. (Eng), AMIE(SL)
E-mail : susinda@xxxxxxxxx
Voice  : 0716049075
**********************************_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev



_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev

-- 
**********************************
Susinda Perera
B.Sc. (Eng), AMIE(SL)
E-mail : susinda@xxxxxxxxx
Voice  : 0716049075
**********************************_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev