On 03/08/2017 02:24 AM, Evgeny
Mandrikov wrote:
Hi,
So seems that the only remaining question - what is
preferred way to do this?
1) Marc proposed to simply keep packages as is and only
mark them as "x-internal".
That's IMHO simple and clear enough. The "x-internal" option is
correctly used by PDE and highlights any usage of those APIs as a
warning.
I tend to believe that those guidelines aren't very pragmatic. If
you have something that's intended to become an API, then renaming
it to "internal.provisional" to rename it later to some other
package is an API breakage, so it's not really nice for adopters.
Also, do you already plan to have "provisional" APIs? If you can
avoid them as long as no-one asks for them, it's simpler for
EclEmma.
Allowing to keep clean distinction between what
"org.eclipse.eclemma.ui" can use and what should not.
'x-friend' allows to do that too.
If I were to do the work, I'd choose the x-internal/x-friend
solution.
However, any of these solutions would work and both are totally
acceptable. It's more a matter of taste than a matter of correctness
IMO.
HTH
|