|
hi,
i finally managed to publish the kryo serializer for ECF along
with an example setup. Please have a look at
https://github.com/ECF/kryo-serialization
Comments and suggestions for improvement are always welcome.
Bye Peter
Am 03.07.2017 um 21:14 schrieb Scott
Lewis:
On 7/3/2017 5:50 AM, Peter Hermsdorf
wrote:
Hi Scott,
Am 30.06.2017 um 19:19 schrieb
Scott Lewis:
Yes it would be better, but it would mean a breaking API
change unfortunately.
I've reopened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=516074
made the addition, and pushed to master. Our hipp instance
appears to me to be down right now, but once it comes up there
will be a build available that includes this change. I
can/will do a maintenance release to include it, but the
question is when?
Thanks again.
Regarding the contribution of a bundle with a Kryo serializer
and an example:
* where to contribute?
My inclination is to add/invite you to the ECF organization at
github, and create a new repo for this.
*
open a bug and create a gerrit change request or should i start
something on my github repo and that might be moved to the ECF
repo when reuqired?
I think the answer for this depends upon what the scope of the
additions will be: e.g. is it a whole new distribution provider
(even if based upon existing providers like the generic)...e.g.
does it have it's own, new container and Namespace types? If the
answer is 'yes' then I would say that you can start something on
your repo, and/or we could move it to ECF org at right time, and
then...if that's your desire...we can/could move it to
eclipse.org.
* I
would modify one the existing "hello" or timeservice examples,
ok? (i remeber that one of them already had code which uses an
ISharedObjectContainer which I also need to register the
serializer)
IMHO the timeservice example would be better than the 'hello'
examples...as the timeservice examples use OSGi RS/RSA...which is
preferred due to the standardization. Or, if you have some new
example/test code, that would be even better.
I've created a separate bundle for the de-/serializer which uses
the DynamicImport-Package directive in the manifest - works as
expected. The other stuff regarding "handling different package
version" was not obvious enough for me to integrate in the first
shot - maybe you or someone else can add / modify that later ...
Yes. This may already be essentially 'dealt with' by the RSA
proxy creation and the generic provider...unless I'm
misinterpreting what you are saying.
Thanks,
Scott
Bye, Peter
|
