Re: [e4-dev] Regenerating the e4 application model changes the MANIFEST.

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Thanks Ed for the information. I opened
https://bugs.eclipse.org/bugs/show_bug.cgi?id=484388 for the change.

Best regards, Lars

On Wed, Dec 2, 2015 at 12:57 PM, Ed Merks <ed.merks@xxxxxxxxx> wrote:
> Lars,
>
> Yes, quite some time ago support was added to do merging of the MANIFEST.MF
> and plugin.xml so that changes to the model are reflected in these files.
> No doubt you want to hand-maintain these two things for the E4 models and
> never want such updates (because you never make changes that would need such
> updates).
>
> Regards,
> Ed
>
>
>
> On 02/12/2015 12:05 PM, Lars Vogel wrote:
>>
>> Ed, can you confirm this change?
>>
>> On Wed, Dec 2, 2015 at 11:58 AM, Tom Schindl
>> <tom.schindl@xxxxxxxxxxxxxxx> wrote:
>>>
>>> Hi,
>>>
>>> I think EMF-Tooling has changed and in former days it did not adjust the
>>> generated MANIFEST.MF/plugin.xml if it already existed, now EMF-Tooling
>>> got smarter and so by default makes such adjustments. But that's just a
>>> guess.
>>>
>>> Tom
>>>
>>> On 02.12.15 11:56, Lars Vogel wrote:
>>>>
>>>> Thanks Ed. I'm still wondering why this is different from the generated
>>>> code.
>>>>
>>>> Maybe Tom, who worked on this model in the past, remember why this was
>>>> changed?
>>>>
>>>> Best regards, Lars
>>>>
>>>> On Tue, Dec 1, 2015 at 2:27 PM, Ed Merks <ed.merks@xxxxxxxxx> wrote:
>>>>>
>>>>> Lars,
>>>>>
>>>>> It's what EMF generates by default.  But you can set the GenModel
>>>>> property
>>>>> Update Classpath to false and then regenerating won't touch the
>>>>> MANIFEST.MF
>>>>> anymore.
>>>>>
>>>>> On Fri, Nov 27, 2015 at 2:05 PM, Lars Vogel <lars.vogel@xxxxxxxxxxx>
>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> to validate a Gerrit contribution from Ed Merks I regenerated the e4
>>>>>> application model located in org.eclipse.e4.ui.model.workbench from
>>>>>> the current master of eclipse.platform.ui
>>>>>>
>>>>>> This regeneration added visibility:=reexport to two packages. To our
>>>>>> modelling exports: Is that expected?
>>>>>>
>>>>>>   org.eclipse.emf.ecore;bundle-version="2.9.0";visibility:=reexport,
>>>>>>   org.eclipse.e4.ui.model.workbench;visibility:=reexport,
>>>>>>
>>>>>> Best regards, Lars
>>>>>>
>>>>>> --
>>>>>> Eclipse Platform UI and e4 project co-lead
>>>>>> CEO vogella GmbH
>>>>>>
>>>>>> Haindaalwisch 17a, 22395 Hamburg
>>>>>> Amtsgericht Hamburg: HRB 127058
>>>>>> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
>>>>>> USt-IdNr.: DE284122352
>>>>>> Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web:
>>>>>> http://www.vogella.com
>>>>>> _______________________________________________
>>>>>> e4-dev mailing list
>>>>>> e4-dev@xxxxxxxxxxx
>>>>>> To change your delivery options, retrieve your password, or
>>>>>> unsubscribe
>>>>>> from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> e4-dev mailing list
>>>>> e4-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe
>>>>> from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>>>>
>>>>
>>>>
>>>
>>> --
>>> Thomas Schindl, CTO
>>> BestSolution.at EDV Systemhaus GmbH
>>> Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
>>> http://www.bestsolution.at/
>>> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
>>> _______________________________________________
>>> e4-dev mailing list
>>> e4-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>>
>>
>>
>
> _______________________________________________
> e4-dev mailing list
> e4-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/e4-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com