[dsdp-tm-dev] Re: RSE API: internal/public api inconsistencies

[David McKnight <dmcknigh@xxxxxxxxxx>]

Okay, I think I got those now.  Let
me know if there's anything I missed.

____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________

"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>

02/04/2007 08:50 AM

To	David McKnight/Toronto/IBM@IBMCA
cc	"Target Management developer discussions" <dsdp-tm-dev@xxxxxxxxxxx>
Subject	RSE API: internal/public api inconsistencies

Hi Dave (& other committers),

top priority for M6 is getting our API done, and here
it's particularly important to get much stuff moved to
"internal" classes.

I have scanned the public interfaces for imports which
bring non-public (internal) types into the interfaces.
Such imports are forbidden, because they mean that
a public API cannot work without using a non-public
type.

Please review the matches below, and ensure that our
public interfaces are consistent wherever possible,
i.e. public API interfaces may only use public API
imports:

IDataElement.java -
org.eclipse.dstore.extra/src/org/eclipse/dstore/extra
  21: import org.eclipse.dstore.internal.extra.IElement;
ILanguageUtilityFactory.java -
org.eclipse.rse.subsystems.files.core/src/org/eclipse/rse/subsystems/fil
es/core
  20: import
org.eclipse.rse.internal.subsystems.files.core.ILanguageUtility;
ISchemaExtender.java -
org.eclipse.dstore.core/src/org/eclipse/dstore/core/model
  20: import org.eclipse.dstore.internal.core.util.ExternalLoader;
ISchemaRegistry.java -
org.eclipse.dstore.core/src/org/eclipse/dstore/core/model
  19: import org.eclipse.dstore.internal.core.util.ExternalLoader;
ISubSystemConfigurationAdapter.java -
org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/util
  32: import
org.eclipse.rse.internal.ui.propertypages.SystemChangeFilterPropertyPage
;
  33: import
org.eclipse.rse.internal.ui.propertypages.SystemFilterStringPropertyPage
;
ISystemFilterWizard.java -
org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/dialogs
  19: import
org.eclipse.rse.internal.ui.filters.SystemFilterDialogInterface;
ISystemLongRunningRequestListener.java -
org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view
  19: import
org.eclipse.rse.internal.ui.view.SystemLongRunningRequestEvent;

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm