[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[dsdp-tm-dev] FW: [dsdp-tm-cvs-commit] dmcknightorg.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystemsSubSystem.java
|
Dave -
I'm worried about this change [below], since it looks like
this is an API change. Before your change, clients could
synchronously call the three methods, (and a job would
be spawned automatically for them), now this is not
possible any more.
Can you please either
- document this change in the build notes, and
- mark the 3 methods as @deprecated
or
- revert your change to the original functionality, and
- mark the 3 methods as @deprecated.
I believe that marking something deprecated is the better
way of saying "don't use this!" as you have done verbally
in the comment.
Of course I'm open to discussion if you have arguments
for making the change as it is.
Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
-----Original Message-----
From: dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx
[mailto:dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx] On Behalf Of Eclipse CVS
Genie
Sent: Monday, December 11, 2006 11:03 PM
To: dsdp-tm-cvs-commit@xxxxxxxxxxx
Subject: [dsdp-tm-cvs-commit]
dmcknightorg.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/org/ec
lipse/rse/core/subsystemsSubSystem.java
Update of
/cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/o
rg/eclipse/rse/core/subsystems
In directory
node4:/tmp/cvs-serv19047/subsystems/org/eclipse/rse/core/subsystems
Modified Files:
SubSystem.java
Log Message:
no synch queries
Index: SubSystem.java
===================================================================
RCS file:
/cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/o
rg/eclipse/rse/core/subsystems/SubSystem.java,v
retrieving revision 1.45
retrieving revision 1.46
diff -C2 -d -r1.45 -r1.46
*** SubSystem.java 7 Dec 2006 19:35:45 -0000 1.45
--- SubSystem.java 11 Dec 2006 22:03:24 -0000 1.46
***************
*** 1988,1991 ****
--- 1988,1993 ----
* displaying for you. Just override
internalResolveFilterString.</b>
* <p>
+ * This method should be avoided in favour of one that runs in a
job.
+ *
* @param filterString filter pattern for objects to return.
* @return the results of resolving the filter string.
***************
*** 1999,2029 ****
if (ok)
{
! Display display = Display.getCurrent();
! if (display != null)
! {
! return internalResolveFilterString(new
NullProgressMonitor(), filterString);
! }
! else
! {
! try
! {
! //dwd this.shell = shell; //FIXME remove this
! ResolveAbsoluteJob job = new
ResolveAbsoluteJob(filterString);
!
! IStatus status = scheduleJob(job, null, shell != null);
! if (status.isOK())
! {
! if (sortResults && (job.getOutputs()!=null))
! return
sortResolvedFilterStringObjects(job.getOutputs());
! else
! return job.getOutputs();
! }
! }
! catch (InterruptedException exc)
! {
! if (shell == null) throw exc;
! else showOperationCancelledMessage(shell);
! }
! }
}
else
--- 2001,2005 ----
if (ok)
{
! return internalResolveFilterString(new
NullProgressMonitor(), filterString);
}
else
***************
*** 2043,2046 ****
--- 2019,2024 ----
* returning them.
*
+ * This method should be avoided in favour of one that runs in a
job.
+ *
* @param filterStrings array of filter patterns for objects to
return.
* @return Array of objects that are the result of resolving all
the filter strings
***************
*** 2063,2096 ****
if (ok)
{
! Display display = Display.getCurrent();
! if (display != null)
! {
! return internalResolveFilterStrings(new
NullProgressMonitor(), filterStrings);
! }
! else
! {
! try
! {
! //dwd this.shell = shell; //FIXME remove this
! ResolveAbsolutesJob job = new
ResolveAbsolutesJob(filterStrings[0], filterStrings);
!
! IStatus status = scheduleJob(job, null, true);
! if (status.isOK())
! {
! if (sortResults && (job.getOutputs()!=null))
! return
sortResolvedFilterStringObjects(job.getOutputs());
! else
! return job.getOutputs();
! }
! }
! catch (InterruptedException exc)
! {
! if (shell == null) throw exc;
! else showOperationCancelledMessage(shell);
! }
! }
}
! else
! System.out.println("in SubSystemImpl.resolveFilterString:
isConnected() returning false!"); //$NON-NLS-1$
return null;
}
--- 2041,2047 ----
if (ok)
{
! return internalResolveFilterStrings(new
NullProgressMonitor(), filterStrings);
}
!
return null;
}
***************
*** 2307,2310 ****
--- 2258,2264 ----
* displaying for you. Override internalResolveFilterString
instead. </b>
* <p>
+ *
+ * This method should be avoided in favour of one that runs in a
job.
+ *
* @param parent Object that is being expanded.
* @param filterString filter pattern for children of parent.
Typically just "*".
***************
*** 2318,2351 ****
if (ok)
{
! Display display = Display.getCurrent();
! if (display != null)
! {
! return internalResolveFilterString(new
NullProgressMonitor(), parent, filterString);
! }
! else
! {
! try
! {
! //dwd this.shell = shell; //FIXME remove this
!
! ResolveRelativeJob job = new
ResolveRelativeJob(filterString, parent);
!
! IStatus status = scheduleJob(job, null, true);
! if (status.isOK())
! {
! if ((job.getOutputs()!=null) &&
(job.getOutputs().length>1))
! return
sortResolvedFilterStringObjects(job.getOutputs());
! else return job.getOutputs();
! }
! }
! catch (InterruptedException exc)
! {
! if (shell == null) throw exc;
! else showOperationCancelledMessage(shell);
! }
! }
}
else
SystemBasePlugin.logDebugMessage(this.getClass().getName(),
"in SubSystemImpl.resolveFilterString: isConnected() returning false!");
//$NON-NLS-1$
return null;
}
--- 2272,2281 ----
if (ok)
{
! return internalResolveFilterString(new
NullProgressMonitor(), parent, filterString);
}
else
+ {
SystemBasePlugin.logDebugMessage(this.getClass().getName(),
"in SubSystemImpl.resolveFilterString: isConnected() returning false!");
//$NON-NLS-1$
+ }
return null;
}
_______________________________________________
dsdp-tm-cvs-commit mailing list
dsdp-tm-cvs-commit@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-tm-cvs-commit
