Hi Mark,
You are right, of course, that working on patches does
create a bit
of work on behalf of both the Contributor and the
existing committers.
My personal opinion, though, is that it's worth taking
this extra
work for at least 3 patches from new committers-to-be in
order
to establish some relationship of trust through publicly
visible
contributions, before making somebody a
committer.
On the other hand, though, I checked the DSDP charter as
well
as the Eclipse Development Process, and couldn't find the
"3 patch" rule anywhere. It must
reads:
"Becoming a Committer is a
privilege that is earned by contributing and showing discipline and good
judgment."
So, it's up to the project (eRCP and DSDP toplevel
project) to define
what "contributing, discipline and judgement"
means to you folks.
I'll thus waive the 3-patch-limit that I wanted to impose
on you, and
let yourself (and the rest of the PMC) decide how you
want to proceed.
I'm not going to vote -1 in this case, I'm casting a "0"
vote since I have
no chance to judge JYHSU I'll need to let others judge.
If others are interested, here
are the docs that I found -- there might be
other docs with the 3-patch-limit
explicitly mentioned, but I didn't find
them.
Cheers,
--
Martin Oberhuber, Senior Member of Technical
Staff, Wind River
Target Management
Project Lead, DSDP PMC Member
Martin,
I agree we should try to be consistent in creating
new committers. I don't agree with you though regarding having a committer
colleague means there is not so much value in John becoming a committer. A
big point of adding John as a committer is to relieve work load on existing
committers, who otherwise have to review and commit his patches. Also,
people tend to come and go, so it is important to keep attrition from
reducing our experienced committers.
Mark
"Oberhuber, Martin"
<Martin.Oberhuber@xxxxxxxxxxxxx>
Sent by: dsdp-pmc-bounces@xxxxxxxxxxx
07/28/2008 11:18 AM
|
Please respond
to
DSDP PMC list
<dsdp-pmc@xxxxxxxxxxx> |
|
|
To
| "DSDP PMC list"
<dsdp-pmc@xxxxxxxxxxx>
|
|
cc
|
|
|
Subject
| RE: [dsdp-pmc] PMC approval
needed for committer vote for
JYHSU |
|
Well,
I haven't voted yet, I just wanted
this matter discussed. But anyhow, I think
that the same rules should apply to everyone, so yes, I
would like to see
3 patches
from John on bugzilla before making him a committer.
If he works so
collaboratively indeed, then this shouldn't be a problem
since he can ask colleagues to apply his
patches easily and there
is
not really so much value in whether he is committer or not.
What's important
to me, is that committers create some understanding
about the legal processes involved in
committing code to the repository.
And having to operate bugzilla patches themselves for a while
forces
them to at least think
a little about what it means to commit some code.
The other thing
is that being a committer does include some rights on
votes, so if only 35% of the existing
committers voted while the others
were out of office, a malicious person might think that some
company
X wanted to bring in a
new member while the members of company Y
had no chance to comment on it. I'm sure that this is not
true, and I
do not know what
sort of company diversity you have in eRCP, so please
consider this just as "food for thought and
could be".
My 2 cents,
--
Martin
Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
From: dsdp-pmc-bounces@xxxxxxxxxxx
[mailto:dsdp-pmc-bounces@xxxxxxxxxxx] On Behalf Of Mark Rogalski
Sent: Monday, July 28,
2008 4:46 PM
To: DSDP PMC list
Cc: DSDP PMC list;
dsdp-pmc-bounces@xxxxxxxxxxx
Subject: RE: [dsdp-pmc] PMC approval
needed for committer vote for JYHSU
I wouldn't read too much into lack of response
during July since it is the height of summer vacation season.
John has been working in
the same office with existing committers so I think his work has been more
collaborative than working independently to submit patches.
So, Martin and Doug, are you
voting "-1" until John submits public patches, and then we will re-vote. How
many patches would you like to see?
Mark
"Oberhuber, Martin"
<Martin.Oberhuber@xxxxxxxxxxxxx>
Sent by:
dsdp-pmc-bounces@xxxxxxxxxxx
07/28/2008 09:40 AM
|
Please respond
to
DSDP PMC list
<dsdp-pmc@xxxxxxxxxxx> |
|
|
To
| "DSDP PMC list"
<dsdp-pmc@xxxxxxxxxxx>
|
|
cc
|
|
|
Subject
| RE: [dsdp-pmc] PMC approval
needed for committer vote for
JYHSU |
|
I
agree,
I'd like to see more public record of JYHSU's contributions. The
cited comments
on https://bugs.eclipse.org/bugs/show_bug.cgi?id=219426 are nice but a bit
thin to grant committer status
right away.
Also, just getting 5 votes out of 13 committers is just 35%
voters within a week,
perhaps you'd want to consider marking some committers
inactive?
Note that John can be a very productive developer for eSWT just
by
providing patches for a while, without full committer status yet,
until
he
has a proven track of records.
Cheers,
--
Martin Oberhuber, Senior Member
of Technical Staff, Wind
River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
From: dsdp-pmc-bounces@xxxxxxxxxxx
[mailto:dsdp-pmc-bounces@xxxxxxxxxxx] On Behalf Of Gaff, Doug
Sent:
Wednesday, July 23, 2008 3:57 PM
To: DSDP PMC
list
Subject: RE: [dsdp-pmc] PMC approval needed for committer
vote for JYHSU
Hi Mark,
It would
be nice to see a list of Bugzilla patches for this committer that
demonstrate his contributions.
Doug
From: dsdp-pmc-bounces@xxxxxxxxxxx [mailto:dsdp-pmc-bounces@xxxxxxxxxxx] On Behalf Of Mark Rogalski
Sent:
Wednesday, July 23, 2008 9:30 AM
To: DSDP PMC list
Cc:
dsdp-pmc@xxxxxxxxxxx; dsdp-pmc-bounces@xxxxxxxxxxx
Subject: Re:
[dsdp-pmc] PMC approval needed for committer vote for JYHSU
+1 from
Rogalski
emo@xxxxxxxxxxx (portal on
behalf of emo)
Sent by:
dsdp-pmc-bounces@xxxxxxxxxxx
07/23/2008 12:00 AM
|
Please respond
to
DSDP PMC list
<dsdp-pmc@xxxxxxxxxxx> |
|
|
To
| dsdp-pmc@xxxxxxxxxxx
|
|
cc
|
|
|
Subject
| [dsdp-pmc] PMC approval needed for
committer vote for JYHSU |
|
dsdp PMC Members,
This automatically
generated message marks the completion of voting for
JYHSU's Committer
status on the dsdp.ercp project. As a PMC member, you can
approve or
disapprove this vote through your My Foundation portal
page:
http://portal.eclipse.org/
JYHSU was nominated by Uriel Liu as follows:
I'd like to
nominate John Hsu, who started his contribution to eRCP from
xmlParser
with the owner Philippe. He answered question in
bugzilla(219426)
recently and also works on other eswt bugs. He will join
the developement
of eSWT on windows flavors.
Vote summary:
5/0/0 with 8 pending
+1 Julian J W Chen
? Gorkem
Ercan
+1 Eric MF Hsu
? Philippe Krief
? Bernd
Lachner
+1 Uriel Liu
? Phil Loats
+1 Petru
Motrescu
? Danail Nachev
+1 Mark Rogalski
? Jussi
Suistomaa
? Aleksi Uotila
? Ken
Walker
_______________________________________________
dsdp-pmc
mailing list
dsdp-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-pmc_______________________________________________
dsdp-pmc mailing
list
dsdp-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-pmc
_______________________________________________
dsdp-pmc mailing
list
dsdp-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-pmc
