Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] The "new user -> ECA -> signed-off by" workflow is broken

Hi Wim,

Thanks for sharing your methodology. I can't speak for the 1% result, but it does not surprise me. The Step 8 is the biggest PITA for contributors on the GitHub PR flow. Many (most?) PR contributors on github never rebase or amend their commits (for other projects). I have had to regularly walk people through the flow of rebasing and amending changes.


Jonah Graham
Kichwa Coders

On Thu, 4 Mar 2021 at 09:52, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

We lose 99% of our casual contributors.

Can you share some insight on how you got this high number? 

I have done a scientific measurement. See below how the process works in practice [1] with drop-off percentages in each step of the process.


This is the original mail that I decided not to send because it was typed in frustration. Take this with a grain of salt; it might not fully accurate reflect the current process:

I again want to ask to remove the "Signed-off-by" requirement. It is not needed because the author and the email are already on the commit. If the project is on GitHub, why do users need to have an Eclipse account when they already have a GitHub account?

It is a PITA because, according to my calculation, this workflow scares away 99% of casual contributors. Here is a replay of the workflow (GitHub):
  1. People file a pull request.
  2. Eclipse checks say: You did not sign the ECA.
  3. 21% of the contributors are confused or don't care and drop off. They say: You merge it for me (which we can't do because it is not our code.)
  4. The rest goes to the website to sign the ECA.
  5. It turns out you need to create an Eclipse account first, so another 53% does not bother. Why is this? People have a Github account; can't we work with that?
  6. The ones left make another change in their PR because that is the only way to retrigger the checks
  7. Eclipse checks say "no signed-off by" footer in the commit message. This is not needed because all information is already in the commit. IT MAKES NO SENSE!!!
  8. So the contributor has to REDO ALL THE COMMITS IN THE PR unless they are some git wizard that can update each commit comment: 25% says "Nah."
1% left of the 77% we still have after step 3
cross-project-issues-dev mailing list
To unsubscribe from this list, visit

Back to the top