Michael, Yes, I agree that "if you
are going to fail a build, a Gerrit build it the best kind to fail"
... but, still, I wouldn't exactly call it a "good thing" when
someone makes an all too common of an error. But, I indeed would not have to "revert"
anything in that case, and that *is* a good thing. :)
As for the "categories". I
was basing my statement on my "local run" in the b3 aggegator
editor and I think I must have something wrong with my install, so I will
try to fix that up today to avoid future false alarms.
Mickael Istria <mistria@xxxxxxxxxx> To:
12/16/2015 04:02 AM Subject:
"Aggregation model is inconsistent" errors Sent by:
On 12/16/2015 09:39 AM, David M Williams wrote: As of right now, the 'head' of the model
is breaking due to invalid "categories" and the "Gerrit
job" is breaking due to invalid "contacts". @David: As far as I can see, the failing Gerrit job is a good thing, since it did
vote -1 on an ongoing review, and it helped the other to fix their contribution
before they could merge it. Where is the CI job highlighting that HEAD is breaking? I'm on https://hudson.eclipse.org/simrel/job/simrel.neon.runaggregator.BUILD__CLEAN/and everything is green.
@All: Like many are already doing, even if you're a SimRel committer and if you're
using the simrel model editor, it's always a good idea to take advantage
of the validation step offered by Gerrit: https://wiki.eclipse.org/Simrel/Contributing_to_Simrel_Aggregation_Build#Contribute_via_a_Gerrit_review. When pushing to Gerrit, the model is automatically validated and you
get a -1 when the model is broken (because of your change, or an earlier
one on your branch but that 2nd case isn't frequent), then you can amend
your patch and submit it again until you get a +1 and permission to merge
via Gerrit if everything seems good. This workflow prevents from breaking
"production" branches. -- Mickael Istria Eclipse developer at JBoss,
by Red Hat My
blog - My
Tweets_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe
from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev