Re: [cross-project-issues-dev] EGit / line ending problems with simrel r

[Ed Willink <ed@xxxxxxxxxxxxx>]

Hi

On 19/08/2012 04:11, David M Williams wrote:

On 16/08/2012 16:30, John Arthorne wrote:
Also note you can select an entire project/folder/etc and do File > Convert Line Delimiters To > Unix to make sure you are in a consistent state.
Beware: This appears to be achieved by a dummy edit using the default editor for each file.

XML files may therefore have their line-wrapping adjusted.

Custom editors that fail to perform dummy edits may actually corrupt files. (Perhaps this is a useful editor test.)

I find this an interesting comment. Is there a bug or something that explains more?

To me it's a bug; quite extraordinary that File->Convert line endings uses editors to do the work. Surely the Team->File Content settings identifies binary files so that everything else gets a simple textual change in a tiny dedicated program. Quite apart from anything else, opening custom editors on thousands of files is really slow.

[If the problem is recomputing character positions for debuggers, surely this is done by the builder not the editor and the builder should be triggered anyway.]

Since an editor is in use, if the editor refuses to save because of a syntax error, the line endings are not corrected; I had one one two line test empty.ecore file that refused to convert. Xtext editable files seem to lose their final line terminator. *.launch files seem to use a bad editor that cannot convert.

    Regards

        Ed Willink