Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Buckminster-based releng-ers - Including an Orbit's source bundle into the generated P2 repository

Hi Folks,

Good news. Once the bug was solved, MDT/OCL counterpart is in place:

- MDT/OCL generated P2 repository contains both lpg.runtime.java and lpg.runtime.java.source plugins.
- The generated org.eclipse.ocl.source feature includes the lpg.runtime.java.source plugin.
- Indigo Modeling M6a contains the lpg.runtime.java.source plugin (and the proper org.eclipse.ocl source feature).

On the other hand, I've also checked an Indigo Modeling M6a Installation (+ OCL Examples + Xtext), from which I think I gathered the list of third party plugins which didn't have corresponding source bundle. The list gets reduced to the following:

- com.google.collect
- com.google.inject
- org.antlr.runtime
- org.apache.batik.* (excepting org.apache.batik.pdf which doesn't have source counterpart)
- org.apache.commons.cli
- org.apache.commons.lang
- org.apache.derby
- org.apache.log4j (only 1.2.15 version has source counterpart, which is the version of the org.apache.log4 bundle which is present in Indigo M5).
- org.apache.lucene.highlighter
- org.apache.lucene.memory
- org.apache.lucene.misc
- org.apache.lucene.queries
- org.apache.lucene.spellchecker
- org.h2
- org.kohsuke.args4j (This one is not in the installation described above, it came from JGIT)
- org.w3c.*

It looks like the bugzilla's fix only solved my problem... I suppose that other projects still need to sort this out.

Best Regards,
Adolfo.

El 03/03/2011 13:08, Adolfo Sánchez-Barbudo Herrera escribió:
Thomas,

Thanks a lot for facing on this.

Bugzilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=338803

Regards,
Adolfo.

El 03/03/2011 12:37, Thomas Hallgren escribió:
Hi Adolfo,

So to summarize, your problem is that although the source bundles are indeed physically present in the target platform they are not promoted to the resulting update site.

If that's the case, can you please enter a bugzilla for this (Product "Buckminster", Component "PDE support") and I'll look into it ASAP.

Thanks,
Thomas Hallgren


On 2011-03-03 12:27, Adolfo Sánchez-Barbudo Herrera wrote:
Martin,

Thanks for participating in the discussion.

I'm the responsible of the these Orbit bundles, so I can affirm that the source bundle does exist. Actually, it was included when using the previous cbi-athena based build system... I've got this problem when migrating to the buckminster build system, and I've only managed to include said source bundles in some downloadable zips. The issue still remains in the generated p2 repository... It looks like other projects should suffer from this issue, and they probably have not realized/managed it.

I've also done more investigations. The list I posted a couple of days was taken by checking that there is not source counterpart in the installation itself. Now, I've checked that there is really a source bundle counterpart in Orbit repository, hence they should be present in the installation, right ?, The list of bundles gets  reduced to the following one:

- com.google.collect
- com.google.inject
- lpg.runtime.java
- org.antlr.runtime
- org.apache.batik.* (excepting org.apache.batik.pdf which doesn't have source counterpart)
- org.apache.commons.cli
- org.apache.commons.lang
- org.apache.derby
- org.apache.log4j (only 1.2.15 version has source counterpart, which is the version of the org.apache.log4 bundle which is present in Indigo M5).
- org.apache.lucene.highlighter
- org.apache.lucene.memory
- org.apache.lucene.misc
- org.apache.lucene.queries
- org.apache.lucene.spellchecker
- org.h2
- org.kohsuke.args4j
- org.w3c.*

I can't affirm that including the lpg.runtime.java.source bundle in our MDT/OCL repository must ensure that the third party source bundle will be present in the final Eclipse installation, but I need firstly fix the issue in our specific project, to start investigation on other different issues, if any at all ;P

Regards,
Adolfo.

El 03/03/2011 10:45, Oberhuber, Martin escribió:

Hi Adolfo,

 

Perhaps I misunderstand your problem, but for some of the bundles you mention the source just doesn’t exist in Orbit CVS and thus also not in the Orbit repo. I know for sure that sat4j doesn’t have source, for instance, and for log4j https://bugs.eclipse.org/bugs/show_bug.cgi?id=320977 is open against Orbit.

 

I agree that Orbit should be providing source wherever possible, but sometimes it is not easy (eg in the case of Xerces where we split the original distro into separate bundles, see http://wiki.eclipse.org/Orbit/Xerces_in_Eclipse

 

HTH,

Martin

--

Martin Oberhuber, SMTS / Product Architect – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: cross-project-issues-dev-bounces@xxxxxxxxxxx [mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Adolfo Sánchez-Barbudo Herrera
Sent: Thursday, March 03, 2011 10:45 AM
To: Cross project issues
Subject: Re: [cross-project-issues-dev] Buckminster-based releng-ers - Including an Orbit's source bundle into the generated P2 repository

 

Thomas,

I think that this is not the solution. Reading the bucky book:

"
cbi.include.source

Controls generation of source features and bundles. When set to true, source bundles are generated
and included in the update site.

Warning:

Source features and bundles are generated and included in the update site unless you
set this property to false. For open source projects this is typically what is wanted,
but it may not be suitable for your project."

This doesn't seem to be the problem, our sources bundles are successfully generated and included into the p2 repository. The problem is that I want a third party bundle and the corresponding source bundle from the target platform to be included in the p2 repository. The binary bundle is included, the source counterpart is not included.

Anyway I tried to give a chance to that property setting explicitly to true. The result was the same.

Any other idea ?

Regards,
Adolfo.
El 01/03/2011 16:26, Thomas Hallgren escribió:

Hi Adolfo,

How do you provision your target platform? Are your source bundles included there? If not, and if Bucky is resolving what's put there, do you have the buckminster.download.source property set to true?

If the source bundles are present in your TP but not in the resulting p2 repository, perhaps you're missing the cbi.include.source = true setting.

HTH,
Thomas Hallgren


On 2011-03-01 15:53, Adolfo Sánchez-Barbudo Herrera wrote:

Hi All,

Retaking this issue up. I've gathered from a Indigo M5 Modeling distribution the list of orbit bundles which doesn't have the corresponding source bundle in said installation:

- com.google.collect
- com.google.inject
- javax.activation
- lpg.runtime.java
- org.antlr.runtime
- org.aopalliance
- org.apache.batik.*
- org.apache.common.cli
- org.apache.commons.lang
- org.apache.derby
- org.apache.log4j
- org.apache.lucene.highlighter
- org.apache.lucene.memory
- org.apache.lucene.misc
- org.apache.lucene.queries
- org.apache.lucene.spellchecker
- org.apache.ws.commons.util
- org.apache.xmlrpc
- org.h2
- org.hoksuke.args4j
- org.sat4j.core
- org.sat4j.pb
- org.w3c.*

I'm wondering why there are a lot plugins which don't have corresponding source bundle. Probably, some of those bundles don't need source counterpart, however it looks like there a lot of them which should probably have their corresponding source bundle...

Could anybody put some light on this ? Any tip/suggestion about what to do with this absence of source bundles?

Thanks in advance,
Adolfo.
El 22/12/2010 11:13, Adolfo Sánchez-Barbudo Herrera escribió:

Hi Folks,

- Moving the question to dev-cross-project to find any Bucky releng-er who had faced this problem -

Detailed background and information around the issue is in the following forum's thread:

http://www.eclipse.org/forums/index.php?t=msg&th=201971&start=0&S=b19a799edb96ebdc69b900b74b0c5d91 <http://www.eclipse.org/forums/index.php?t=msg&th=201971&start=0&S=b19a799edb96ebdc69b900b74b0c5d91>

As an high level overview, I'm trying to solve the following issue:

In our M4 Modeling Distribution the following bundle, which is obtained from an Orbit's p2 repo, is included into the distribution's set of plugins:

lpg.runtime.java

However, the corresponding lpg.runtime.java.source is not included.

Have any buckminter-based releng-er faced a similar problem ?

Best Regards,
Adolfo.

 

--

Open Canarias, S.L.

Adolfo Sánchez-Barbudo Herrera
adolfosbh(at)opencanarias(dot)com
C/Elías Ramos González, 4, ofc. 304
38001 SANTA CRUZ DE TENERIFE
Tel.: +34 922 240231

 
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



 
 
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

 

--

Open Canarias, S.L.

Adolfo Sánchez-Barbudo Herrera
adolfosbh(at)opencanarias(dot)com
C/Elías Ramos González, 4, ofc. 304
38001 SANTA CRUZ DE TENERIFE
Tel.: +34 922 240231

 

_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

--
Open Canarias, S.L.
Adolfo Sánchez-Barbudo Herrera
adolfosbh(at)opencanarias(dot)com
C/Elías Ramos González, 4, ofc. 304
38001 SANTA CRUZ DE TENERIFE
Tel.: +34 922 240231
_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

--
Open Canarias, S.L.
Adolfo Sánchez-Barbudo Herrera
adolfosbh(at)opencanarias(dot)com
C/Elías Ramos González, 4, ofc. 304
38001 SANTA CRUZ DE TENERIFE
Tel.: +34 922 240231

--
Open Canarias, S.L.
Adolfo Sánchez-Barbudo Herrera
adolfosbh(at)opencanarias(dot)com
C/Elías Ramos González, 4, ofc. 304
38001 SANTA CRUZ DE TENERIFE
Tel.: +34 922 240231

Back to the top