[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: Re[2]: [cdt-patch] WinDbg NATIVE defines have wrong package name
|
Thanks, Hasse. I have applied the patch. I had change the packaging just
before committing and didn't get a chance to retest. Thanks for catching
this.
Cheers,
Doug Schaefer, IBM's Eclipse CDT Architect
Ottawa (Palladium), Ontario, Canada
Hasse Hellberg <hasse@xxxxxxxxxxxxxxx>
Sent by: cdt-patch-admin@xxxxxxxxxxx
07/12/2004 02:55 AM
Please respond to
cdt-patch
To
Douglas Schaefer <cdt-patch@xxxxxxxxxxx>
cc
Subject
Re[2]: [cdt-patch] WinDbg NATIVE defines have wrong package name
Hello Douglas,
Here's the file!
Yea, thought the patch text looked a bit broken.
Will send by file if it looks broken again!
Monday, July 12, 2004, 2:06:19 AM, you wrote:
DS> Thanks, Hasse,
DS> However, could you attach the patch as a file. The mail system has
broken
DS> up the lines and I can't apply it.
DS> Doug Schaefer, IBM's Eclipse CDT Architect
DS> Ottawa (Palladium), Ontario, Canada
DS> Hasse Hellberg <hasse@xxxxxxxxxxxxxxx>
DS> Sent by: cdt-patch-admin@xxxxxxxxxxx
DS> 07/11/2004 06:12 AM
DS> Please respond to
DS> cdt-patch
DS> To
DS> cdt-patch@xxxxxxxxxxx
DS> cc
DS> Subject
DS> [cdt-patch] WinDbg NATIVE defines have wrong package name
DS> Hello cdt-patch-request and especially Doug Schaefer ,
DS> Here's the first in a line of updates to the WinDbg plugging.
DS> I'm a compleat newbee on this type of patch system so
DS> please inform me on anything i do wrong :)
DS> Adding 4 fixes/changes to 4 files in the plugging
DS> "org.eclipse.cdt.debug.win32.core".
DS> All 4 .cpp files in the "native" catalog need the same fix.
DS> And that is: NATIVE defines have wrong package name!
DS> Adding text "_core" fixes the package name.
DS> Fixing this and rebuilding the dll file resulted in success!
DS> Now the run-time workbench launch and the debugger
DS> can be selected and used. However new bugs was discovered
DS> now when debugging "work". If somebody doesn't makes it before me
DS> I will try to solve them :)
DS> -Hasse
DS> Index: frame.cpp
DS> ===================================================================
DS> RCS file:
DS>
/home/tools/org.eclipse.cdt-debug/org.eclipse.cdt.debug.win32.core/native/frame.cpp,v
DS> retrieving revision 1.1
DS> diff -u -r1.1 frame.cpp
DS> --- frame.cpp 5 Jul 2004 20:46:51 -0000 1.1
DS> +++ frame.cpp 11 Jul 2004 09:35:15 -0000
DS> @@ -16,7 +16,7 @@
DS> static jmethodID addVariableID;
DS> -#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_cdi_WinDbgStackFrame_##name
DS> +#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_core_cdi_WinDbgStackFrame_##name
DS> NATIVE(void, initNative)(JNIEnv * env, jclass cls)
DS> {
DS> Index: process.cpp
DS> ===================================================================
DS> RCS file:
DS>
/home/tools/org.eclipse.cdt-debug/org.eclipse.cdt.debug.win32.core/native/process.cpp,v
DS> retrieving revision 1.1
DS> diff -u -r1.1 process.cpp
DS> --- process.cpp 5 Jul 2004 20:46:51 -0000 1.1
DS> +++ process.cpp 11 Jul 2004 09:35:15 -0000
DS> @@ -152,7 +152,7 @@
DS> TerminateProcess(pi.hProcess, -1);
DS> }
DS> -#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_cdi_WinDbgProcess_##name
DS> +#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_core_cdi_WinDbgProcess_##name
DS> static jfieldID pID;
DS> Index: target.cpp
DS> ===================================================================
DS> RCS file:
DS>
/home/tools/org.eclipse.cdt-debug/org.eclipse.cdt.debug.win32.core/native/target.cpp,v
DS> retrieving revision 1.1
DS> diff -u -r1.1 target.cpp
DS> --- target.cpp 5 Jul 2004 20:46:51 -0000 1.1
DS> +++ target.cpp 11 Jul 2004 09:35:15 -0000
DS> @@ -303,7 +303,7 @@
DS> // JNI interface
DS> -#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_cdi_WinDbgTarget_##name
DS> +#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_core_cdi_WinDbgTarget_##name
DS> static jfieldID pID;
DS> Index: thread.cpp
DS> ===================================================================
DS> RCS file:
DS>
/home/tools/org.eclipse.cdt-debug/org.eclipse.cdt.debug.win32.core/native/thread.cpp,v
DS> retrieving revision 1.1
DS> diff -u -r1.1 thread.cpp
DS> --- thread.cpp 5 Jul 2004 20:46:51 -0000 1.1
DS> +++ thread.cpp 11 Jul 2004 09:35:15 -0000
DS> @@ -13,7 +13,7 @@
DS> #include <stdio.h>
DS> #include <jni.h>
DS> -#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_cdi_WinDbgThread_##name
DS> +#define NATIVE(type, name) extern "C" JNIEXPORT type JNICALL
DS> Java_org_eclipse_cdt_debug_win32_core_cdi_WinDbgThread_##name
DS> static jfieldID processHandleID;
DS> static jfieldID threadHandleID;
DS> _______________________________________________
DS> cdt-patch mailing list
DS> cdt-patch@xxxxxxxxxxx
DS> http://dev.eclipse.org/mailman/listinfo/cdt-patch
DS> _______________________________________________
DS> cdt-patch mailing list
DS> cdt-patch@xxxxxxxxxxx
DS> http://dev.eclipse.org/mailman/listinfo/cdt-patch
--
Best regards,
Hasse mailto:hasse@xxxxxxxxxxxxxxx
#### patch.txt has been removed from this note on July 12, 2004 by Douglas
Schaefer
