[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-patch] CDT 1.2 serial line speed patch
|
>
> Alain,
>
> Thanks for integrating the patch.
>
> Moving the code from MIPlugin.java to GDBServerDebugger.java is an
> improvement over the original patch, but I think your proposed
> modification may have introduced the following behavior changes:
>
> 1. A -tty argument is now passed to gdb.
>
> 2. The original code used to set the suspended state to true. That isn't
> happening anymore.
>
> 3. The second parameter to the Session constructor (attach) has the
> value false. The original flow of execution set it to true.
>
> This is just based on looking at the diffs. I'm not sure whether the
> user would actually see any differences. However, I would appreciate a
> second look on your part.
>
Done, the wrong method was use, thanks.
BTW, I've almost missed this, next time it would be better to have the
comments in the PR/Defect for the proper followups.
