Re: [cdt-patch] CDT 1.2 serial line speed patch

[Ashish Karkare <ashish.karkare@xxxxxxxxxxx>]

Alain,

Thanks for integrating the patch.

Moving the code  from MIPlugin.java  to GDBServerDebugger.java is an 
improvement over the original patch,  but I think your proposed 
modification  may have introduced the following behavior changes:

1.  A -tty argument is now passed to gdb.

2. The original code used to set the suspended state to true. That isn't 
happening anymore.

3. The second parameter to the Session constructor (attach) has the 
value false.  The original flow of execution set it to true.

This is just based on looking at the diffs. I'm not sure whether the 
user would actually see any differences. However, I would appreciate a 
second look on your part.

Regards,

Ashish.

> Alain Magloire wrote:
>
>  
>
> > > 3. GDBServerDebugger.java
> > >   Extracts  serial speed value and passes it to createCSession().
> > >
> > > 4. MIPlugin.java
> > >   Sends remotebaud command prior to sending target attach.
> > >      
> >
> > (4) is rejected.  You are implying that args[3] args[4] must be of a certain
> > value.  Currently the helper function in the MIPlugin.java is use by a
> > variety of other users.  Something like this is incorrect.  Your propose
> > code been move to GDBServerDebugger.java. (see patch)
> Alain,
>
>