Re: [cdt-dev] Nice new feature needing a review

[Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>]

Thanks Marc-André! Very much appreciated.

On Wed, 2019-03-20 at 12:32 -0400, Marc-Andre Laperle wrote:

Hi! I’ll start reviewing this tonight. Once the review is far enough I’ll deal with the CQ.

Cheers,

Marc-André

On Mar 20, 2019, at 10:01, Doug Schaefer <dschaefer@xxxxxxxxxxxxxx> wrote:

I'm definitely not an expert on the refactoring work so won't commit to commiting it ☺. I just wanted to point out that this probably does cross the line into requiring a CQ. It's a pretty big contribution. So that will need to be done as well.

Doug.

On Wed, 2019-03-20 at 09:56 -0400, Jonah Graham wrote:

Hello folks,

Is there a committer who can take a look at https://bugs.eclipse.org/303870 - "Source-> Implement Virtual Method"?

Marco Stornelli who has been making lots of great contributions recently has picked up work in progress started by Pavel Marek and got it ready for submission. 

If you are able, please add yourself as a reviewer and review away.

Thanks,

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

_______________________________________________

cdt-dev mailing list

cdt-dev@xxxxxxxxxxx

To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__www.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwICAg&c=yzoHOc_ZK-sxl-kfGNSEvlJYanssXN3q-lhj0sp26wE&r=NrrbvTHWa2Nbp_kAN0Hl1o3lM1WAwSes64uBjxjNhMc&m=0YWUzPwRzMzcGLwIIavuHlj1vPhUdTdTJziKALZDeew&s=eyUHjEmf0P8SzqFY41TJTrtQDQA2i6-AWtUzMBolgkc&e=

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cdt-dev