|Re: [cdt-dev] Formatting and EPLv2|
I tried this, and the script made changes to a bunch of other source files, in addition to the ones my patch modifies. Should I be comitting those changes as well?
This is with my patch rebased onto the master branch, so it seems to me that those other files should already be formatted correctly.
From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Sent: November 23, 2018 6:06 PM
To: Nathan Ridge
Cc: CDT General developers list.
Subject: Re: [cdt-dev] Formatting and EPLv2
Yes, you can do that.
Run releng/scripts/check_code_cleanliness.sh<https: git.eclipse.org="" r="" #="" c="" 132975="" 4="" releng="" scripts="" check_code_cleanliness.sh="">
You need an ECLIPSE environment variable that points at the eclipse install to use. It defaults to ~/buildtools/eclipse-SDK-4.9/eclipse (the value that works on the build machine). Once the script runs it will leave you to stage/commit any changes it has made.
Kichwa Coders Ltd.
On Fri, 23 Nov 2018 at 18:01, Nathan Ridge <zeratul976@xxxxxxxxxxx<mailto:zeratul976@xxxxxxxxxxx>> wrote:
> There is now a CI job to check code formatting and a few other rules. The job is https://ci.eclipse.org/cdt/job/cdt-verify-code-cleanliness and it runs https://git.eclipse.org/r/#/c/132975/4/releng/scripts/check_code_cleanliness.sh which has some rules in it.
> It means that gerrit CI check will fail if you have formatting/whitespace issues. Please let me know what you think.
Is there a local command I can run to reformat my code (which perhaps has an old patch applied) to satisfy the check?
Back to the top