Re: [cdt-dev] Formatting and EPLv2

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hello folks,

The cdt master branch for CDT 9.6.0 is now open again. The code has been updated to EPLv2 and the code has all been formatted and had some cleanup applied to it. The HEAD gerrit is https://git.eclipse.org/r/#/c/132930/ and if you click on the Submitted Together tab you can see all 20 patches that are part of this change, or for those that prefer using their git client:

$ git log --oneline 3cf0297769..ff75ae80fa

ff75ae80fa (HEAD -> master, origin/master, origin/HEAD) Bug 540373: Cleanup: Remove trailing whitespace in properties files

be35c7327d Bug 540373: Cleanup: Remove trailing whitespace in Java files

b4031b5a8b Bug 540373: Safely remove trailing whitespace from MANIFEST.MF

aa1040a21a Bug 540373: Remove '(non-Javadoc)' comments

eeb3006e27 Bug 540373: Cleanup: Remove redundant semicolons

caf2292768 Bug 540373: Cleanup: Remove redundant type arguments

8844a8f9f2 Bug 540373: Cleanup: Remove unnecessary casts

8985c7b63f Bug 540373: Cleanup: Add missing annotations

a923614c73 Bug 540373: Cleanup: Organize Imports

170e654b47 Bug 540373: Cleanup: Format & Remove trailing whitespace

35996a5c5c Bug 540373: Standard .settings auto applied

4f9a44aa3d Bug 540373: Standard .settings for JDT/PDE

37f0f660c8 Bug 540373: Fix tests that rely on format of Java code

086e6e30b7 Bug 540373: Fix tests that rely on whitespace at end of line

871c91ee5e Bug 540373: Fix declaration to interface

c5c5412f8d Bug 540373: Remove invalid javadoc API tags

f70a8b35c1 Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.sh

f0ce92d3b5 Bug 540371: normalize files before applying EPLv2

cd61252736 Bug 540371: Script for updating to EPLv2

48d2271a58 Bug 540373: Normalize newlines with .gitattributes

Please let me know if you have any questions/concerns.

Thank you,

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On Fri, 23 Nov 2018 at 00:29, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Correction correct HEAD is https://git.eclipse.org/r/#/c/132797/ downlooad/checkout with:

git fetch https://git.eclipse.org/r/cdt/org.eclipse.cdt refs/changes/97/132797/4 && git checkout FETCH_HEAD

That will give the commits I have +2'ed already.

There are a couple of other commits that I may get in, but they are not ready yet. They are also much smaller and don't touch all the Java files like the above ones.

https://git.eclipse.org/r/#/c/132930/

https://git.eclipse.org/r/#/c/132929/

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On Fri, 23 Nov 2018 at 00:26, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Hi Nate and other cdt-devers,

No changes to be made to global preferences as every project will have formatter settings applied in the project itself, overridding workspace settings. See https://git.eclipse.org/r/#/c/132779/ and https://git.eclipse.org/r/#/c/132780/

In fact all relevant settings to formatting, errors, warning, code cleanup and editor save actions are now standard across all CDT projects. The formatter settings are standard Eclipse with the only modification to not format any comments at all (there are too many hand crafted comments in CDT to let formatter touch that automatically). There are error and warning level changes because the projects were haphazard and this has now been standardised, however that may lead to some warnings that were not on before that are now annoying, if so, please raise it as an issue and we can revisit. The idea is to make it easier to work with CDT code.

Finally, there are editor actions on save now:

This means that when you save the file it will be auto-formatted and otherwise cleaned up according to the common configured rules. 

The final tests of the gerrits are running now. I plan to submit during the day tomorrow unless I hear concerns from anyone. The HEAD of the changes is https://git.eclipse.org/r/#/c/132930/ so you can download/checkout the whole set with git fetch https://git.eclipse.org/r/cdt/org.eclipse.cdt refs/changes/30/132930/1 && git checkout FETCH_HEAD

Thanks,

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On Thu, 22 Nov 2018 at 23:13, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:

> Finally, please don't forget to reformat/cleanup/check license on any code you are adding.

Any particular changes we should be making to Preferences -> Java -> Code Style -> Formatter?

Thanks,
Nate