|Re: [cdt-dev] Formatting and EPLv2|
Correction correct HEAD is https://git.eclipse.org/r/#/c/132797/ downlooad/checkout with:git fetch https://git.eclipse.org/r/cdt/org.eclipse.cdt refs/changes/97/132797/4 && git checkout FETCH_HEADThat will give the commits I have +2'ed already.There are a couple of other commits that I may get in, but they are not ready yet. They are also much smaller and don't touch all the Java files like the above ones.On Fri, 23 Nov 2018 at 00:26, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:Hi Nate and other cdt-devers,No changes to be made to global preferences as every project will have formatter settings applied in the project itself, overridding workspace settings. See https://git.eclipse.org/r/#/c/132779/ and https://git.eclipse.org/r/#/c/132780/In fact all relevant settings to formatting, errors, warning, code cleanup and editor save actions are now standard across all CDT projects. The formatter settings are standard Eclipse with the only modification to not format any comments at all (there are too many hand crafted comments in CDT to let formatter touch that automatically). There are error and warning level changes because the projects were haphazard and this has now been standardised, however that may lead to some warnings that were not on before that are now annoying, if so, please raise it as an issue and we can revisit. The idea is to make it easier to work with CDT code.Finally, there are editor actions on save now:This means that when you save the file it will be auto-formatted and otherwise cleaned up according to the common configured rules.The final tests of the gerrits are running now. I plan to submit during the day tomorrow unless I hear concerns from anyone. The HEAD of the changes is https://git.eclipse.org/r/#/c/132930/ so you can download/checkout the whole set with git fetch https://git.eclipse.org/r/cdt/org.eclipse.cdt refs/changes/30/132930/1 && git checkout FETCH_HEADThanks,JonahOn Thu, 22 Nov 2018 at 23:13, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:> Finally, please don't forget to reformat/cleanup/check license on any code you are adding.
Any particular changes we should be making to Preferences -> Java -> Code Style -> Formatter?
Back to the top