Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Many new warnings in CDT tests and elsewhere

> Is this fallout from the recent cleanliness changes?

Yes it is. The change is a result of standardizing the warning/error settings across all the projects. I will review those specific instances and tune the common settings. 

Because of the standardisation the settings are applied per project and override the workspace settings. This means everyone should be seeing the same warnings/errors too.

Sorry for the extra yellow in your code :-)  I have reopened Bug 540373 so please feel free to add items there.


Jonah Graham
Kichwa Coders Ltd.

On Sat, 24 Nov 2018 at 07:31, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:
It looks like a lot of new warnings appeared in the CDT codebase.

A lot of them are in test code. For example, in test files like, every import from org.eclipse.cdt.internal.* packages is marked with a "discouraged access" warning.

The tests have always used internal APIs; there is no reason to warn about that.

There are also new warnings in non-test code, some of which seem bogus. For example, in "ASTCompletionNode implements non-API interface IASTCompletionNode". That make no sense - ASTCompletionNode is in the same package as IASTCompletionNode, and it is our canonical implementation.

Is this fallout from the recent cleanliness changes?

cdt-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top