[cdt-dev] Many new warnings in CDT tests and elsewhere

[Nathan Ridge <zeratul976@xxxxxxxxxxx>]

It looks like a lot of new warnings appeared in the CDT codebase.

A lot of them are in test code. For example, in test files like AST2CPPTests.java, every import from org.eclipse.cdt.internal.* packages is marked with a "discouraged access" warning.

The tests have always used internal APIs; there is no reason to warn about that.

There are also new warnings in non-test code, some of which seem bogus. For example, in ASTCompletionNode.java: "ASTCompletionNode implements non-API interface IASTCompletionNode". That make no sense - ASTCompletionNode is in the same package as IASTCompletionNode, and it is our canonical implementation.

Is this fallout from the recent cleanliness changes?

Thanks,
Nate