| Re: [cdt-dev] Request for respin of 9.5 |
_______________________________________________Yes, as I mentioned in the bug it broke serial flash launching when the Terminal is open on the same port, i.e. the main use case for the serial flash launch feature. I really should have tested this earlier and my apologies on that.
With your change, the Terminal never resumes after the launch finishes and an exception appears in the log from the SerialPort read1 method. I reverted the commit and the Terminal now resumes correctly.
I will be writing a couple of articles on this work flow in the next couple of weeks and I need this to be working since it’s the star of the show.
If you can get a change in that doesn’t break this workflow, we’d be happy to spin a 9.5.1 to pick it up.
Doug.
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Waqas Ilyas
Sent: Sunday, June 17, 2018 12:00 AM
To: cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] Request for respin of 9.5
Hi Doug,
There seems to be confusion around the fix you mentioned, it doesn't break existing functionality. I just wrote tests that validated it, as well as additional tests that discovered NEW problems. Unless you have discovered a new issue with the fix itself, we should include that fix in the release because we need it.
Regards,
Waqas
On Sat, Jun 16, 2018 at 4:14 PM Doug Schaefer <dschaefer@xxxxxxxxxxxxxx> wrote:
Sorry gang, I proved to be too trusting and now need to revert a commit that was made for the Serial Port. It breaks the serial launch work flows used by the ESP32 here and it probably breaks Arduino. These are two things that I’d like to promote with the Eclipse C/C++ IDE for Photon.
Any objections?
Doug.
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
Sent: Saturday, June 16, 2018 4:57 PM
To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Subject: [cdt-dev] Candidate for 9.5.1
Hey gang, my friends at Espressif found a bug in Core Build with how GCCToolChain handles relative include paths at discovery time. But is here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535972
I have a fix in the system and it should be pushed to the 9.5 branch as soon as it passes testing. I’d like to get this out in time for when the ESP-IDF adds official CMake support. Not sure when that is but it could be an early 9.5.1. Let me know if you haven any concerns about that.
BTW, I have no interest other than personal here other than fixing GCCToolChain. The Adafruit Huzzah32 with Espressif’s ESP32 is a pretty nice hobbyist board and I have some home projects I want to work on ☺. And I’ll be writing an article about it as an example of using the Eclipse C/C++ IDE’s now built-in CMake support with the Launch Bar and Serial Flash Target. Pretty cool stuff.
Thanks!
Doug.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev