I don't think this is wise, but I bet there's a technical reason (like guaranteeing backward compatibility for JDK 7?) so I'm not quite ready to just change this blindly.
Should we use the Photon-stack based build bits instead?
Also worthy of note:
tm.terminal depends on CDT. The default master build uses 8.8.1 [6]; the Photon profile uses 9.4 [7].
Is it bad to be shipping something destined to run with 9.x when we're building it against 8.x? Feels bad to me, but again, perhaps there's a reason for this ?
Finally, I discovered that the tm.terminal build also depends on tm.rse [8], whose build in turn also depends on tm.terminal [9]. This circular build-time dependency is worrisome... and should be broken. I honestly don't know which project to build first in order.
We could merge the builds, move stuff around, etc. Again, WDYT?
[8] org.eclipse.tm.terminal.view.ui.rse depends on org.eclipse.rse.core, org.eclipse.rse.subsystems.files.core, org.eclipse.rse.ui
[9] org.eclipse.rse.terminals.ui depends on org.eclipse.tm.terminal.control